You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2023/08/28 17:04:58 UTC

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7895: Flexible URI for connection with DB

weizhouapache commented on code in PR #7895:
URL: https://github.com/apache/cloudstack/pull/7895#discussion_r1307689512


##########
framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java:
##########
@@ -1143,6 +1134,38 @@ public static void initDataSource(Properties dbProps) {
         }
     }
 
+    private static String getConnectionUri(Properties dbProps, String loadBalanceStrategy, String driver, boolean useSSL, String schema) {

Review Comment:
   I suggest to use `databaseName` instead of `schema`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org