You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org> on 2006/01/16 09:06:22 UTC
[jira] Created: (MYFACES-1031) test cases didnt reset the
facesContext to null
test cases didnt reset the facesContext to null
-----------------------------------------------
Key: MYFACES-1031
URL: http://issues.apache.org/jira/browse/MYFACES-1031
Project: MyFaces
Type: Bug
Components: General
Versions: Nightly
Reporter: Mario Ivankovits
Attachments: test_ctx_null.diff
If a test-case sets a facesContext and forgets to remove it again subsequent tests may fail if they use "null" as wanted facesContext.
The patch introduce a new AbstractTestCase which
*) ensure the facesContext is null in startUp()
*) set the facesContext to null in tearDown()
I changed UISelectManyTest and UIComponentBaseTest to use this new super class
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1031) test cases didnt reset the
facesContext to null
Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1031?page=comments#action_12362825 ]
Mario Ivankovits commented on MYFACES-1031:
-------------------------------------------
Yes, you are right.
Shall I do it?
> test cases didnt reset the facesContext to null
> -----------------------------------------------
>
> Key: MYFACES-1031
> URL: http://issues.apache.org/jira/browse/MYFACES-1031
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Reporter: Mario Ivankovits
> Assignee: Simon Kitching
> Attachments: AbstractTestCase.java, FacesContextHelper.java, test_ctx_null.diff
>
> If a test-case sets a facesContext and forgets to remove it again subsequent tests may fail if they use "null" as wanted facesContext.
> The patch introduce a new AbstractTestCase which
> *) ensure the facesContext is null in startUp()
> *) set the facesContext to null in tearDown()
> I changed UISelectManyTest and UIComponentBaseTest to use this new super class
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1031) test cases didnt reset the
facesContext to null
Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1031?page=comments#action_12362833 ]
Mario Ivankovits commented on MYFACES-1031:
-------------------------------------------
works like a charme!
Thank you!
> test cases didnt reset the facesContext to null
> -----------------------------------------------
>
> Key: MYFACES-1031
> URL: http://issues.apache.org/jira/browse/MYFACES-1031
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Reporter: Mario Ivankovits
> Assignee: Simon Kitching
> Attachments: AbstractTestCase.java, AbstractTestCase.java, FacesContextHelper.java, test_ctx_null.diff, test_ctx_null.diff
>
> If a test-case sets a facesContext and forgets to remove it again subsequent tests may fail if they use "null" as wanted facesContext.
> The patch introduce a new AbstractTestCase which
> *) ensure the facesContext is null in startUp()
> *) set the facesContext to null in tearDown()
> I changed UISelectManyTest and UIComponentBaseTest to use this new super class
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-1031) test cases didnt reset the
facesContext to null
Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1031?page=all ]
Mario Ivankovits updated MYFACES-1031:
--------------------------------------
Attachment: test_ctx_null.diff
> test cases didnt reset the facesContext to null
> -----------------------------------------------
>
> Key: MYFACES-1031
> URL: http://issues.apache.org/jira/browse/MYFACES-1031
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Reporter: Mario Ivankovits
> Attachments: test_ctx_null.diff
>
> If a test-case sets a facesContext and forgets to remove it again subsequent tests may fail if they use "null" as wanted facesContext.
> The patch introduce a new AbstractTestCase which
> *) ensure the facesContext is null in startUp()
> *) set the facesContext to null in tearDown()
> I changed UISelectManyTest and UIComponentBaseTest to use this new super class
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1031) test cases didnt reset the
facesContext to null
Posted by "Simon Kitching (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1031?page=comments#action_12362830 ]
Simon Kitching commented on MYFACES-1031:
-----------------------------------------
Ok, I've committed this (with just some minor tweaks to copyright dates and some added comments; hope this is ok).
Mario, can you please confirm that this works on your system? (it does on mine).
> test cases didnt reset the facesContext to null
> -----------------------------------------------
>
> Key: MYFACES-1031
> URL: http://issues.apache.org/jira/browse/MYFACES-1031
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Reporter: Mario Ivankovits
> Assignee: Simon Kitching
> Attachments: AbstractTestCase.java, AbstractTestCase.java, FacesContextHelper.java, test_ctx_null.diff, test_ctx_null.diff
>
> If a test-case sets a facesContext and forgets to remove it again subsequent tests may fail if they use "null" as wanted facesContext.
> The patch introduce a new AbstractTestCase which
> *) ensure the facesContext is null in startUp()
> *) set the facesContext to null in tearDown()
> I changed UISelectManyTest and UIComponentBaseTest to use this new super class
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-1031) test cases didnt reset the
facesContext to null
Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1031?page=all ]
Mario Ivankovits updated MYFACES-1031:
--------------------------------------
Attachment: AbstractTestCase.java
new home
> test cases didnt reset the facesContext to null
> -----------------------------------------------
>
> Key: MYFACES-1031
> URL: http://issues.apache.org/jira/browse/MYFACES-1031
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Reporter: Mario Ivankovits
> Assignee: Simon Kitching
> Attachments: AbstractTestCase.java, AbstractTestCase.java, FacesContextHelper.java, test_ctx_null.diff, test_ctx_null.diff
>
> If a test-case sets a facesContext and forgets to remove it again subsequent tests may fail if they use "null" as wanted facesContext.
> The patch introduce a new AbstractTestCase which
> *) ensure the facesContext is null in startUp()
> *) set the facesContext to null in tearDown()
> I changed UISelectManyTest and UIComponentBaseTest to use this new super class
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-1031) test cases didnt reset the
facesContext to null
Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1031?page=all ]
Mario Ivankovits updated MYFACES-1031:
--------------------------------------
Attachment: AbstractTestCase.java
the super class for myfaces tests
> test cases didnt reset the facesContext to null
> -----------------------------------------------
>
> Key: MYFACES-1031
> URL: http://issues.apache.org/jira/browse/MYFACES-1031
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Reporter: Mario Ivankovits
> Attachments: AbstractTestCase.java, FacesContextHelper.java, test_ctx_null.diff
>
> If a test-case sets a facesContext and forgets to remove it again subsequent tests may fail if they use "null" as wanted facesContext.
> The patch introduce a new AbstractTestCase which
> *) ensure the facesContext is null in startUp()
> *) set the facesContext to null in tearDown()
> I changed UISelectManyTest and UIComponentBaseTest to use this new super class
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (MYFACES-1031) test cases didnt reset the
facesContext to null
Posted by "Simon Kitching (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1031?page=all ]
Simon Kitching closed MYFACES-1031:
-----------------------------------
Fix Version: Nightly
Resolution: Fixed
> test cases didnt reset the facesContext to null
> -----------------------------------------------
>
> Key: MYFACES-1031
> URL: http://issues.apache.org/jira/browse/MYFACES-1031
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Reporter: Mario Ivankovits
> Assignee: Simon Kitching
> Fix For: Nightly
> Attachments: AbstractTestCase.java, AbstractTestCase.java, FacesContextHelper.java, test_ctx_null.diff, test_ctx_null.diff
>
> If a test-case sets a facesContext and forgets to remove it again subsequent tests may fail if they use "null" as wanted facesContext.
> The patch introduce a new AbstractTestCase which
> *) ensure the facesContext is null in startUp()
> *) set the facesContext to null in tearDown()
> I changed UISelectManyTest and UIComponentBaseTest to use this new super class
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-1031) test cases didnt reset the
facesContext to null
Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1031?page=all ]
Mario Ivankovits updated MYFACES-1031:
--------------------------------------
Attachment: FacesContextHelper.java
context helper copied from commons
> test cases didnt reset the facesContext to null
> -----------------------------------------------
>
> Key: MYFACES-1031
> URL: http://issues.apache.org/jira/browse/MYFACES-1031
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Reporter: Mario Ivankovits
> Attachments: AbstractTestCase.java, FacesContextHelper.java, test_ctx_null.diff
>
> If a test-case sets a facesContext and forgets to remove it again subsequent tests may fail if they use "null" as wanted facesContext.
> The patch introduce a new AbstractTestCase which
> *) ensure the facesContext is null in startUp()
> *) set the facesContext to null in tearDown()
> I changed UISelectManyTest and UIComponentBaseTest to use this new super class
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1031) test cases didnt reset the
facesContext to null
Posted by "Simon Kitching (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1031?page=comments#action_12362823 ]
Simon Kitching commented on MYFACES-1031:
-----------------------------------------
Mario, the AbstractTestCase class is currently under javax.faces.component.
What do you think of putting it under org.apache.myfaces, like FacesContextHelper? They seem to belong together, and I guess this
base class is useful for tests other than those under javax.faces.component....
> test cases didnt reset the facesContext to null
> -----------------------------------------------
>
> Key: MYFACES-1031
> URL: http://issues.apache.org/jira/browse/MYFACES-1031
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Reporter: Mario Ivankovits
> Assignee: Simon Kitching
> Attachments: AbstractTestCase.java, FacesContextHelper.java, test_ctx_null.diff
>
> If a test-case sets a facesContext and forgets to remove it again subsequent tests may fail if they use "null" as wanted facesContext.
> The patch introduce a new AbstractTestCase which
> *) ensure the facesContext is null in startUp()
> *) set the facesContext to null in tearDown()
> I changed UISelectManyTest and UIComponentBaseTest to use this new super class
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-1031) test cases didnt reset the
facesContext to null
Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1031?page=all ]
Mario Ivankovits updated MYFACES-1031:
--------------------------------------
Attachment: test_ctx_null.diff
moved abstractTestCase to its new home
> test cases didnt reset the facesContext to null
> -----------------------------------------------
>
> Key: MYFACES-1031
> URL: http://issues.apache.org/jira/browse/MYFACES-1031
> Project: MyFaces
> Type: Bug
> Components: General
> Versions: Nightly
> Reporter: Mario Ivankovits
> Assignee: Simon Kitching
> Attachments: AbstractTestCase.java, FacesContextHelper.java, test_ctx_null.diff, test_ctx_null.diff
>
> If a test-case sets a facesContext and forgets to remove it again subsequent tests may fail if they use "null" as wanted facesContext.
> The patch introduce a new AbstractTestCase which
> *) ensure the facesContext is null in startUp()
> *) set the facesContext to null in tearDown()
> I changed UISelectManyTest and UIComponentBaseTest to use this new super class
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira