You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2017/01/19 17:59:33 UTC
Review Request 55724: AMBARI-19629. Move schemaTool invocation out of
configure() to hive_metastore start()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55724/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian Toader.
Bugs: AMBARI-19629
https://issues.apache.org/jira/browse/AMBARI-19629
Repository: ambari
Description
-------
Extract `create_metastore_schema()`, call it from `start()` instead of `configure()`.
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 16273c77b2bf4affb4b53f33e5eb40f0e9a1122c
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py d1ecd6593b4926fe39de11f81a101409ad14a13d
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 0a98894bfe74eb53684c6aaef77511b950bb776d
ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py f9e910b8bfed478e0419a30230cbc60b71f12e0a
Diff: https://reviews.apache.org/r/55724/diff/
Testing
-------
Manual test: install cluster via blueprint, verify Hive Metastore starts successfully.
Unit tests:
```
$ mvn -am -pl ambari-server -DskipSurefireTests clean test
...
Total run:1159
Total errors:0
Total failures:0
OK
...
[INFO] Ambari Server ..................................... SUCCESS
```
Thanks,
Attila Doroszlai
Re: Review Request 55724: AMBARI-19629. Move schemaTool invocation
out of configure() to hive_metastore start()
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55724/#review162329
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 19, 2017, 5:59 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55724/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 5:59 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19629
> https://issues.apache.org/jira/browse/AMBARI-19629
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Extract `create_metastore_schema()`, call it from `start()` instead of `configure()`.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 16273c77b2bf4affb4b53f33e5eb40f0e9a1122c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py d1ecd6593b4926fe39de11f81a101409ad14a13d
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 0a98894bfe74eb53684c6aaef77511b950bb776d
> ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py f9e910b8bfed478e0419a30230cbc60b71f12e0a
>
> Diff: https://reviews.apache.org/r/55724/diff/
>
>
> Testing
> -------
>
> Manual test: install cluster via blueprint, verify Hive Metastore starts successfully.
>
> Unit tests:
>
> ```
> $ mvn -am -pl ambari-server -DskipSurefireTests clean test
> ...
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] Ambari Server ..................................... SUCCESS
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 55724: AMBARI-19629. Move schemaTool invocation
out of configure() to hive_metastore start()
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55724/#review162328
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Jan. 19, 2017, 12:59 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55724/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 12:59 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19629
> https://issues.apache.org/jira/browse/AMBARI-19629
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Extract `create_metastore_schema()`, call it from `start()` instead of `configure()`.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 16273c77b2bf4affb4b53f33e5eb40f0e9a1122c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py d1ecd6593b4926fe39de11f81a101409ad14a13d
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 0a98894bfe74eb53684c6aaef77511b950bb776d
> ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py f9e910b8bfed478e0419a30230cbc60b71f12e0a
>
> Diff: https://reviews.apache.org/r/55724/diff/
>
>
> Testing
> -------
>
> Manual test: install cluster via blueprint, verify Hive Metastore starts successfully.
>
> Unit tests:
>
> ```
> $ mvn -am -pl ambari-server -DskipSurefireTests clean test
> ...
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] Ambari Server ..................................... SUCCESS
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 55724: AMBARI-19629. Move schemaTool invocation
out of configure() to hive_metastore start()
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55724/#review162326
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Jan. 19, 2017, 6:59 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55724/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2017, 6:59 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-19629
> https://issues.apache.org/jira/browse/AMBARI-19629
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Extract `create_metastore_schema()`, call it from `start()` instead of `configure()`.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 16273c77b2bf4affb4b53f33e5eb40f0e9a1122c
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_metastore.py d1ecd6593b4926fe39de11f81a101409ad14a13d
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 0a98894bfe74eb53684c6aaef77511b950bb776d
> ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py f9e910b8bfed478e0419a30230cbc60b71f12e0a
>
> Diff: https://reviews.apache.org/r/55724/diff/
>
>
> Testing
> -------
>
> Manual test: install cluster via blueprint, verify Hive Metastore starts successfully.
>
> Unit tests:
>
> ```
> $ mvn -am -pl ambari-server -DskipSurefireTests clean test
> ...
> Total run:1159
> Total errors:0
> Total failures:0
> OK
> ...
> [INFO] Ambari Server ..................................... SUCCESS
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>