[GitHub] [apisix] Yiyiyimu commented on pull request #4524: feat: support lua_shared_dict variable in ngx_tpl.lua loaded via configuration file

[GitBox <gi...@apache.org>]

Yiyiyimu commented on pull request #4524:
URL: https://github.com/apache/apisix/pull/4524#issuecomment-874263787


   Hi @Applenice I think the reason is the lib [`skywalking-nginx-lua`](https://github.com/apache/skywalking-nginx-lua) use `tracing_buffer` as the shared-dict name. Maybe you could propose a PR there to make it configurable. 
   I'm not sure if there are other choices, so waiting for @spacewander's opinion  
   ```
   $ grep -r 'tracing_buffer' apisix 
   
   ./apisix/cli/ngx_tpl.lua:    lua_shared_dict tracing_buffer       10m; # plugin: skywalking
   ./apisix/plugins/skywalking.lua:    local metadata_shdict = ngx.shared.tracing_buffer
   ./conf/nginx.conf:    lua_shared_dict tracing_buffer       10m; # plugin: skywalking
   ./t/servroot/conf/nginx.conf:    lua_shared_dict tracing_buffer       10m;    # plugin skywalking
   ./t/APISIX.pm:    lua_shared_dict tracing_buffer       10m;    # plugin skywalking
   ./deps/lib/luarocks/rocks-5.1/skywalking-nginx-lua/0.4-1/doc/README.md:    lua_shared_dict tracing_buffer 100m;
   ./deps/lib/luarocks/rocks-5.1/skywalking-nginx-lua/0.4-1/doc/README.md:        local metadata_buffer = ngx.shared.tracing_buffer
   ./deps/share/lua/5.1/skywalking/client.lua:    local metadata_buffer = ngx.shared.tracing_buffer
   ./deps/share/lua/5.1/skywalking/client.lua:    local metadata_buffer = ngx.shared.tracing_buffer
   ./deps/share/lua/5.1/skywalking/client.lua:    local queue = ngx.shared.tracing_buffer
   ./deps/share/lua/5.1/skywalking/tracer.lua:local metadata_shdict = ngx.shared.tracing_buffer
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org