[GitHub] [flink] zentol commented on a change in pull request #17555: [FLINK-24381][table] Add support for setting Options sensitive

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #17555:
URL: https://github.com/apache/flink/pull/17555#discussion_r738072523



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java
##########
@@ -360,10 +380,18 @@ public static Catalog createCatalog(
                                 catalogName,
                                 options.entrySet().stream()
                                         .map(
-                                                optionEntry ->
-                                                        stringifyOption(
+                                                optionEntry -> {
+                                                    if (GlobalConfiguration.isSensitive(

Review comment:
       I think we should move this into `stringifyOption`. Currently it can easily happen that a bit of new code is added that does not do these checks.
   Case in point, there are 2 more locations in this class that you did not modify. There are 5 usages of this method, and only `#enrichNoMatchingConnectorError` doesn't need it.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org