You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vincbeck (via GitHub)" <gi...@apache.org> on 2026/06/08 16:35:31 UTC
[PR] Fix team consumer asset filtering [airflow]
vincbeck opened a new pull request, #68242:
URL: https://github.com/apache/airflow/pull/68242
Fix team consumer asset filtering by setting the default value to `None` instead of empty list. Empty list basically means to not allow any team (besides the one the Dag is in).
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix team consumer asset filtering [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #68242:
URL: https://github.com/apache/airflow/pull/68242#discussion_r3376071666
##########
airflow-core/src/airflow/assets/manager.py:
##########
@@ -197,9 +197,8 @@ def _filter_dags_by_team(
:param asset_model: the AssetModel whose scheduled_dags carry allow_producer_teams.
:param source_is_api: True if the event was triggered via the REST API (not a DAG task).
:param session: SQLAlchemy session.
- :param allow_consumer_teams: list of team names allowed to consume. Empty/None means no filtering.
- :param allow_global_consumers: whether teamless consumers are allowed. Only applies when
- allow_consumer_teams is non-empty.
+ :param allow_consumer_teams: list of team names allowed to consume. None means no team-based filtering.
Review Comment:
Good idea :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix team consumer asset filtering [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #68242:
URL: https://github.com/apache/airflow/pull/68242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix team consumer asset filtering [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #68242:
URL: https://github.com/apache/airflow/pull/68242#discussion_r3375987608
##########
airflow-core/src/airflow/assets/manager.py:
##########
@@ -197,9 +197,8 @@ def _filter_dags_by_team(
:param asset_model: the AssetModel whose scheduled_dags carry allow_producer_teams.
:param source_is_api: True if the event was triggered via the REST API (not a DAG task).
:param session: SQLAlchemy session.
- :param allow_consumer_teams: list of team names allowed to consume. Empty/None means no filtering.
- :param allow_global_consumers: whether teamless consumers are allowed. Only applies when
- allow_consumer_teams is non-empty.
+ :param allow_consumer_teams: list of team names allowed to consume. None means no team-based filtering.
Review Comment:
Maybe describe what empty list does, since it's distinctly different than None?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org