You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2012/09/11 20:00:08 UTC

[jira] [Updated] (HADOOP-8789) Tests setLevel(Level.OFF) should be Level.ERROR

     [ https://issues.apache.org/jira/browse/HADOOP-8789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Collins updated HADOOP-8789:
--------------------------------

          Resolution: Fixed
       Fix Version/s: 2.0.3-alpha
    Target Version/s:   (was: 2.0.2-alpha)
              Status: Resolved  (was: Patch Available)

I've committed this and merged to branch-2. Thanks Andy.
                
> Tests setLevel(Level.OFF) should be Level.ERROR
> -----------------------------------------------
>
>                 Key: HADOOP-8789
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8789
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 2.0.1-alpha
>            Reporter: Andy Isaacson
>            Assignee: Andy Isaacson
>            Priority: Minor
>             Fix For: 2.0.3-alpha
>
>         Attachments: hdfs-3911.txt
>
>
> Multiple tests have code like
> {code}
> ((Log4JLogger)LogFactory.getLog(FSNamesystem.class)).getLogger().setLevel(Level.OFF);
> {code}
> Completely disabling logs from given classes with {{Level.OFF}} is a bad idea and makes debugging other test failures, especially intermittent test failures like HDFS-3664, difficult.  Instead the code should use {{Level.ERROR}} to reduce verbosity.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira