You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Olivier Fayau (JIRA)" <ji...@apache.org> on 2014/03/06 16:40:44 UTC

[jira] [Updated] (FELIX-4447) Regression in ScrShellCommand (NPE caused by falsy regex)

     [ https://issues.apache.org/jira/browse/FELIX-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Fayau updated FELIX-4447:
---------------------------------

    Description: 
Using felix console and DS (scr + shell +shell tui), the command scr doesn't work anymore.
Sample : 
scr list
-> Unable to execute command: java.lang.NullPointerException
java.lang.NullPointerException
	at org.apache.felix.scr.impl.ScrShellCommand.help(ScrShellCommand.java:116)
	at org.apache.felix.scr.impl.ScrShellCommand.execute(ScrShellCommand.java:75)
	at org.apache.felix.shell.impl.Activator$ShellServiceImpl.executeCommand(Activator.java:249)
	at org.apache.felix.shell.tui.Activator$ShellTuiRunnable.run(Activator.java:184)
	at java.lang.Thread.run(Unknown Source)


Looking at source code, in ScrShellCommand.execute(), command is splitted by the falsy regex "//s".
This should be "\\s+" instead.


  was:
Using felix console and DS (scr + shell +shell tui), the command scr doesn't work anymore (NPE instead of result).
Sample : 
scr list
-> Unable to execute command: java.lang.NullPointerException
java.lang.NullPointerException
	at org.apache.felix.scr.impl.ScrShellCommand.help(ScrShellCommand.java:116)
	at org.apache.felix.scr.impl.ScrShellCommand.execute(ScrShellCommand.java:75)
	at org.apache.felix.shell.impl.Activator$ShellServiceImpl.executeCommand(Activator.java:249)
	at org.apache.felix.shell.tui.Activator$ShellTuiRunnable.run(Activator.java:184)
	at java.lang.Thread.run(Unknown Source)


Looking at source code, in ScrShellCommand.execute(), command is splitted by the falsy regex "//s".
This should be "\\s+" instead.



> Regression in ScrShellCommand (NPE caused by falsy regex)
> ---------------------------------------------------------
>
>                 Key: FELIX-4447
>                 URL: https://issues.apache.org/jira/browse/FELIX-4447
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR), Script Console Plugin
>    Affects Versions: scr-1.8.0, scr-1.8.2
>            Reporter: Olivier Fayau
>              Labels: easyfix
>
> Using felix console and DS (scr + shell +shell tui), the command scr doesn't work anymore.
> Sample : 
> scr list
> -> Unable to execute command: java.lang.NullPointerException
> java.lang.NullPointerException
> 	at org.apache.felix.scr.impl.ScrShellCommand.help(ScrShellCommand.java:116)
> 	at org.apache.felix.scr.impl.ScrShellCommand.execute(ScrShellCommand.java:75)
> 	at org.apache.felix.shell.impl.Activator$ShellServiceImpl.executeCommand(Activator.java:249)
> 	at org.apache.felix.shell.tui.Activator$ShellTuiRunnable.run(Activator.java:184)
> 	at java.lang.Thread.run(Unknown Source)
> Looking at source code, in ScrShellCommand.execute(), command is splitted by the falsy regex "//s".
> This should be "\\s+" instead.



--
This message was sent by Atlassian JIRA
(v6.2#6252)