[GitHub] [pinot] Jackie-Jiang commented on pull request #8074: For DISTINCT_COUNT, automatically convert Set to HyperLogLog when cardinality is too high

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on pull request #8074:
URL: https://github.com/apache/pinot/pull/8074#issuecomment-1028462180


   > @Jackie-Jiang How will you deal with the new input `hllLog2m=8;hllConversionThreshold=10` when we fall back to the new function with config? The original distinctcount function currently doesn't get the second parameter.
   
   @snleee If user doesn't explicitly call the new function, distinctcount will be rewritten to the default one (log2m=12, conversionThreshold=10k)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org