[jira] [Commented] (CALCITE-746) Fix false positives when Apache RAT is run from outside maven

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14571679#comment-14571679 ] 

Julian Hyde commented on CALCITE-746:
-------------------------------------

I investigated this. RAT's maven plugin cannot read an exclusions file (see RAT-161). So we'd have to maintain the list of exclusions in two places -- in the pom.xml, and in .rat-excludes.

Maintaining the data in two places seems to me to increase the chance of error.

See also SPARK-1493. (The Spark team don't use maven, so I suppose that they run Rat by hand.)



> Fix false positives when Apache RAT is run from outside maven
> -------------------------------------------------------------
>
>                 Key: CALCITE-746
>                 URL: https://issues.apache.org/jira/browse/CALCITE-746
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Julian Hyde
>             Fix For: next
>
>
> In http://mail-archives.apache.org/mod_mbox/incubator-general/201505.mbox/%3C55654545.4090202%40apache.org%3E Brane wrote:
> {noformat}
>  RAT emits warnings:
> Files with unapproved licenses:
>   ./git.properties
>   ./avatica/src/main/resources/META-INF/services/java.sql.Driver
>   ./core/src/main/resources/META-INF/services/java.sql.Driver
>   ./example/csv/src/test/resources/bug/DATE.csv
>   ./example/csv/src/test/resources/bug/WACKY_COLUMN_NAMES.csv
>   ./example/csv/src/test/resources/bug/archers.json
>   ./example/csv/src/test/resources/sales/DEPTS.csv
> *****************************************************
> Archives:
>  + ./example/csv/src/test/resources/sales/EMPS.csv.gz
> These are clearly false positives, and I see that the pom.xml file
> contains exclusions for these files. I suggest also providing a
> rat-excludes file with the same exclusion rules, so that RAT can be run
> on the tree without going through maven (and trusting the pom.xml :).
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)