You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "appletreeisyellow (via GitHub)" <gi...@apache.org> on 2023/04/18 22:07:58 UTC

[GitHub] [arrow] appletreeisyellow commented on a diff in pull request #35213: GH-35118: [FlightSQL] More use `int32` to refer to 32-bit integers rather than `int`

appletreeisyellow commented on code in PR #35213:
URL: https://github.com/apache/arrow/pull/35213#discussion_r1170612611


##########
format/FlightSql.proto:
##########
@@ -1064,8 +1064,8 @@ enum Searchable {
  * The returned schema will be:
  * <
  *   type_name: utf8 not null (The name of the data type, for example: VARCHAR, INTEGER, etc),
- *   data_type: int not null (The SQL data type),
- *   column_size: int (The maximum size supported by that column.
+ *   data_type: int32 not null (The SQL data type),
+ *   column_size: int32 (The maximum size supported by that column.
  *                     In case of exact numeric types, this represents the maximum precision.
  *                     In case of string types, this represents the character length.
  *                     In case of datetime data types, this represents the length in characters of the string representation.

Review Comment:
   Sure! Updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org