You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/09 14:00:16 UTC
[GitHub] [airflow] potiuk opened a new pull request #20773: Add roles to create_user test
potiuk opened a new pull request #20773:
URL: https://github.com/apache/airflow/pull/20773
Flask App Builder 3.4.3 made role and conf_password obligatory
when creating user:
https://github.com/dpgaspar/Flask-AppBuilder/pull/1758
Our test for user creation did not have the role set (though the
UI used it and the cient also allows to set it).
This change adds the `roles` in our tests to enable upgrade
to FAB 3.4.3 for the CI (currently tests in main fail because of
the test failure)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20773: Add roles to create_user test
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20773:
URL: https://github.com/apache/airflow/pull/20773#issuecomment-1008495173
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #20773: Add roles to create_user test
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20773:
URL: https://github.com/apache/airflow/pull/20773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20773: Add roles to create_user test
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20773:
URL: https://github.com/apache/airflow/pull/20773#issuecomment-1008326814
Would love to merge this one, to get the scheduler run overniht green :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org