Re: [PR] IGNITE-22155 Introduce a new component to manage replication lifecycle [ignite-3]

["sanpwc (via GitHub)" <gi...@apache.org>]

sanpwc commented on code in PR #3768:
URL: https://github.com/apache/ignite-3/pull/3768#discussion_r1609482288


##########
modules/replica-lifecycle/src/main/java/org/apache/ignite/internal/datareplication/ReplicaLifecycleManager.java:
##########
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.datareplication;
+
+import static org.apache.ignite.internal.lang.IgniteSystemProperties.getBoolean;
+import static org.apache.ignite.internal.util.CompletableFutures.nullCompletedFuture;
+
+import java.util.concurrent.CompletableFuture;
+import org.apache.ignite.internal.manager.IgniteComponent;
+
+/**
+ * The main responsibilities of this class:
+ * - Start the appropriate replication nodes (RAFT nodes at the moment) and logic replicas on the zone creation.

Review Comment:
   Let's not mention raft here. Given manager will start Replica and Replica will start Raft internally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org