[GitHub] [incubator-linkis] peacewong commented on a diff in pull request #2458: Opt format code

[GitBox <gi...@apache.org>]

peacewong commented on code in PR #2458:
URL: https://github.com/apache/incubator-linkis/pull/2458#discussion_r918878779


##########
linkis-commons/linkis-storage/pom.xml:
##########
@@ -36,7 +36,6 @@
             <groupId>org.apache.linkis</groupId>
             <artifactId>linkis-common</artifactId>
             <version>${linkis.version}</version>
-            <scope>provided</scope>

Review Comment:
   Why remove provided?



##########
linkis-orchestrator/linkis-computation-orchestrator/src/main/scala/org/apache/linkis/orchestrator/computation/monitor/EngineConnMonitor.scala:
##########
@@ -138,8 +138,6 @@ object EngineConnMonitor extends Logging {
                 endJobByEngineInstance(status._1)
             }
           }
-        case o: Any =>
-          logger.error(s"Status of engine ${status._1.toString} is ${status._2}")

Review Comment:
   should update to case _: log



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org