You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/12/05 10:49:54 UTC
[GitHub] [james-project] quantranhong1999 opened a new pull request, #1350: JAMES-3754 Searching support IMAP savedate extension
quantranhong1999 opened a new pull request, #1350:
URL: https://github.com/apache/james-project/pull/1350
TODO:
- [ ] Lucene implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #1350: JAMES-3754 Searching support IMAP savedate extension
Posted by GitBox <gi...@apache.org>.
Arsnael commented on PR #1350:
URL: https://github.com/apache/james-project/pull/1350#issuecomment-1340350513
Conflicts in the branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael merged pull request #1350: JAMES-3754 Searching support IMAP savedate extension
Posted by GitBox <gi...@apache.org>.
Arsnael merged PR #1350:
URL: https://github.com/apache/james-project/pull/1350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 commented on pull request #1350: JAMES-3754 Searching support IMAP savedate extension
Posted by GitBox <gi...@apache.org>.
quantranhong1999 commented on PR #1350:
URL: https://github.com/apache/james-project/pull/1350#issuecomment-1352697867
Can we merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a diff in pull request #1350: JAMES-3754 Searching support IMAP savedate extension
Posted by GitBox <gi...@apache.org>.
chibenwa commented on code in PR #1350:
URL: https://github.com/apache/james-project/pull/1350#discussion_r1040353751
##########
mailbox/api/src/main/java/org/apache/james/mailbox/model/SearchQuery.java:
##########
@@ -1278,6 +1296,50 @@ public String toString() {
}
}
+ /**
+ * Filters on the save date.
+ */
+ public static class SaveDateCriterion extends Criterion {
+
+ private final DateOperator operator;
+
+ public SaveDateCriterion(DateOperator operator) {
+ super();
+ this.operator = operator;
+ }
+
+ /**
+ * Gets the search operation and value to be evaluated.
+ *
+ * @return the <code>Operator</code>, not null
+ */
+ public DateOperator getOperator() {
+ return operator;
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hashCode(operator);
+ }
+
+ @Override
+ public boolean equals(Object obj) {
Review Comment:
```suggestion
public final boolean equals(Object obj) {
```
##########
mailbox/api/src/main/java/org/apache/james/mailbox/model/SearchQuery.java:
##########
@@ -1278,6 +1296,50 @@ public String toString() {
}
}
+ /**
+ * Filters on the save date.
+ */
+ public static class SaveDateCriterion extends Criterion {
+
+ private final DateOperator operator;
+
+ public SaveDateCriterion(DateOperator operator) {
+ super();
Review Comment:
Not needed?
##########
mailbox/api/src/main/java/org/apache/james/mailbox/model/SearchQuery.java:
##########
@@ -1278,6 +1296,50 @@ public String toString() {
}
}
+ /**
+ * Filters on the save date.
+ */
+ public static class SaveDateCriterion extends Criterion {
+
+ private final DateOperator operator;
+
+ public SaveDateCriterion(DateOperator operator) {
+ super();
+ this.operator = operator;
+ }
+
+ /**
+ * Gets the search operation and value to be evaluated.
+ *
+ * @return the <code>Operator</code>, not null
+ */
+ public DateOperator getOperator() {
+ return operator;
+ }
+
+ @Override
+ public int hashCode() {
Review Comment:
```suggestion
public final int hashCode() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1350: JAMES-3754 Searching support IMAP savedate extension
Posted by GitBox <gi...@apache.org>.
quantranhong1999 commented on code in PR #1350:
URL: https://github.com/apache/james-project/pull/1350#discussion_r1044456918
##########
mailbox/cassandra/pom.xml:
##########
@@ -129,6 +129,11 @@
<artifactId>james-server-task-memory</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>${james.groupId}</groupId>
+ <artifactId>james-server-testing</artifactId>
+ <scope>runtime</scope>
Review Comment:
The maven test module `james-server-testing` with scope `test` is not transitive to other testing modules (lead to NoDefClassFound..).
So I use `runtime` scope: `This scope indicates that the dependency is not required for compilation, but is for execution. Maven includes a dependency with this scope in the runtime and test classpaths, but not the compile classpath.`
rf: https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#dependency-scope
Better idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #1350: JAMES-3754 Searching support IMAP savedate extension
Posted by GitBox <gi...@apache.org>.
Arsnael commented on PR #1350:
URL: https://github.com/apache/james-project/pull/1350#issuecomment-1342014241
Conflicts, rebase please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] vttranlina commented on a diff in pull request #1350: JAMES-3754 Searching support IMAP savedate extension
Posted by GitBox <gi...@apache.org>.
vttranlina commented on code in PR #1350:
URL: https://github.com/apache/james-project/pull/1350#discussion_r1044409651
##########
mailbox/cassandra/pom.xml:
##########
@@ -129,6 +129,11 @@
<artifactId>james-server-task-memory</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>${james.groupId}</groupId>
+ <artifactId>james-server-testing</artifactId>
+ <scope>runtime</scope>
Review Comment:
scope test is better?
##########
mailbox/jpa/pom.xml:
##########
@@ -89,6 +89,11 @@
<artifactId>james-server-data-jpa</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>${james.groupId}</groupId>
+ <artifactId>james-server-testing</artifactId>
+ <scope>runtime</scope>
Review Comment:
scope test is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org