You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/15 10:21:10 UTC

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #16401: Add 'queued' state to DagRun

ephraimbuddy commented on a change in pull request #16401:
URL: https://github.com/apache/airflow/pull/16401#discussion_r651654584



##########
File path: tests/api_connexion/endpoints/test_dag_run_endpoint.py
##########
@@ -532,7 +535,7 @@ class TestGetDagRunsEndDateFilters(TestDagRunEndpoint):
             (
                 f"api/v1/dags/TEST_DAG_ID/dagRuns?end_date_lte="
                 f"{(timezone.utcnow() + timedelta(days=1)).isoformat()}",
-                ["TEST_DAG_RUN_ID_1"],
+                ["TEST_DAG_RUN_ID_1", "TEST_DAG_RUN_ID_2"],

Review comment:
       This is because instead of changing 'running' to 'queued' for many affected tests, I decided to pass any given state to the second DagModel at line 135(_create_test_dag_run function). So when 'success' is passed to the function's state argument, then two dag_runs will have their end_date set. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org