You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/05/20 06:07:05 UTC

[GitHub] [spark] bozhang2820 opened a new pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

bozhang2820 opened a new pull request #32603:
URL: https://github.com/apache/spark/pull/32603


   ### What changes were proposed in this pull request?
   This PR changes the antlr4-runtime version from 4.8-1 to 4.8.
   
   ### Why are the changes needed?
   Version 4.8 is the official release version, with a proper release note (see https://github.com/antlr/antlr4/releases) and artifiacts listed in https://www.antlr.org/download/index.html.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Will rely on tests in the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32603:
URL: https://github.com/apache/spark/pull/32603#issuecomment-844825691


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43253/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32603:
URL: https://github.com/apache/spark/pull/32603#issuecomment-844771633


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43253/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32603:
URL: https://github.com/apache/spark/pull/32603#issuecomment-844733128


   **[Test build #138731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138731/testReport)** for PR 32603 at commit [`b8f20cc`](https://github.com/apache/spark/commit/b8f20cccef5a1a6d17fd32c5e43a1f76a7230f5f).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu commented on pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #32603:
URL: https://github.com/apache/spark/pull/32603#issuecomment-844855140


   Thanks! Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32603:
URL: https://github.com/apache/spark/pull/32603#issuecomment-844877813


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138731/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32603:
URL: https://github.com/apache/spark/pull/32603#issuecomment-844861177


   **[Test build #138731 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138731/testReport)** for PR 32603 at commit [`b8f20cc`](https://github.com/apache/spark/commit/b8f20cccef5a1a6d17fd32c5e43a1f76a7230f5f).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] bozhang2820 commented on pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
bozhang2820 commented on pull request #32603:
URL: https://github.com/apache/spark/pull/32603#issuecomment-844740119


   > Or, `4.8` is the successor of `4.8-1`?
   
   Yes technically `4.8-1` is smaller than `4.8` (see https://semver.org/). Maybe we can change "Bump" to "Update" instead?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32603:
URL: https://github.com/apache/spark/pull/32603#issuecomment-844740663


   Oh, got it. Thank you for the explanation!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32603:
URL: https://github.com/apache/spark/pull/32603#issuecomment-844732843


   cc @maropu and @dongjoon-hyun FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] maropu closed pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
maropu closed pull request #32603:
URL: https://github.com/apache/spark/pull/32603


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32603:
URL: https://github.com/apache/spark/pull/32603#issuecomment-844877813


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138731/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun edited a comment on pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #32603:
URL: https://github.com/apache/spark/pull/32603#issuecomment-844740663


   Oh, got it. Thank you for the explanation! In that case, it looks good to me. I was confused at that part.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32603:
URL: https://github.com/apache/spark/pull/32603#issuecomment-844737805


   Or, `4.8` is the successor of `4.8-1`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32603:
URL: https://github.com/apache/spark/pull/32603#issuecomment-844825691


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43253/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32603:
URL: https://github.com/apache/spark/pull/32603#issuecomment-844813678


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43253/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #32603: [SPARK-35457][BUILD] Bump ANTLR runtime version to 4.8

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32603:
URL: https://github.com/apache/spark/pull/32603#issuecomment-844733128


   **[Test build #138731 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138731/testReport)** for PR 32603 at commit [`b8f20cc`](https://github.com/apache/spark/commit/b8f20cccef5a1a6d17fd32c5e43a1f76a7230f5f).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org