[jira] [Commented] (FLINK-7489) Remove job lifecycle methods from public JobMasterGateway interface

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136872#comment-16136872 ] 

ASF GitHub Bot commented on FLINK-7489:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/4573

    [FLINK-7489] Remove startJobExecution and suspendExecution from JobMasterGateway

    ## What is the purpose of the change
    
    The job lifecycle methods `startJobExecution` and `suspendExecution` should not be exposed as RPCs. Therefore, this commit removes them from the JobMasterGateway definition.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink removeJMRPCs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4573.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4573
    
----
commit 4b1088243a24fc3791c56eff37e1ca5fada8afbd
Author: Till Rohrmann <tr...@apache.org>
Date:   2017-08-22T14:33:05Z

    [FLINK-7489] Remove startJobExecution and suspendExecution from JobMasterGateway
    
    The job lifecycle methods should not be exposed as RPCs. Therefore, this commit
    removes them from the JobMasterGateway definition.

----


> Remove job lifecycle methods from public JobMasterGateway interface
> -------------------------------------------------------------------
>
>                 Key: FLINK-7489
>                 URL: https://issues.apache.org/jira/browse/FLINK-7489
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>
> The {{JobMaster}} exposes its job lifecycle methods {{startJobExecution}} and {{suspendExecution}} via its {{JobMasterGateway}} to the public. I think these methods should not be exposed because it allows other components to affect the job execution without proper reason. Only the {{JobManagerRunner}} should be responsible for calling these methods and has direct access to the {{JobMaster}} instance. Therefore, these methods can directly be implemented by the {{JobMaster}} without exposing them via the {{JobMasterGateway}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)