You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/04 00:00:31 UTC
[GitHub] [tvm] CircleSpin opened a new pull request #8191: Onnx eyelike
CircleSpin opened a new pull request #8191:
URL: https://github.com/apache/tvm/pull/8191
This PR implements the onnx eyelike operator and it's optional components.
@masahi @jwfromm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #8191: Onnx eyelike
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #8191:
URL: https://github.com/apache/tvm/pull/8191#issuecomment-854274558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #8191: Onnx eyelike
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #8191:
URL: https://github.com/apache/tvm/pull/8191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a change in pull request #8191: Onnx eyelike
Posted by GitBox <gi...@apache.org>.
masahi commented on a change in pull request #8191:
URL: https://github.com/apache/tvm/pull/8191#discussion_r645208010
##########
File path: tests/python/frontend/onnx/test_forward.py
##########
@@ -4241,9 +4266,9 @@ def verify_cumsum(indata, axis, exclusive=0, reverse=0, type="float32"):
"test_cumsum_2d_negative_axis/",
"test_det_2d/",
"test_det_nd/",
- "test_eyelike_populate_off_main_diagonal/",
- "test_eyelike_with_dtype/",
- "test_eyelike_without_dtype/",
+ # "test_eyelike_populate_off_main_diagonal/",
+ # "test_eyelike_with_dtype/",
+ # "test_eyelike_without_dtype/",
Review comment:
Remove the commented lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a change in pull request #8191: Onnx eyelike
Posted by GitBox <gi...@apache.org>.
masahi commented on a change in pull request #8191:
URL: https://github.com/apache/tvm/pull/8191#discussion_r645207863
##########
File path: src/driver/driver_api.cc
##########
@@ -185,6 +185,17 @@ IRModule lower(te::Schedule sch, const Array<te::Tensor>& args, const std::strin
return mod;
}
+TVM_REGISTER_GLOBAL("driver.lower").set_body_typed([](te::Schedule sch, const Array<te::Tensor>& args, const String& name, const Map<te::Tensor, tir::Buffer>& binds) {
Review comment:
Remove the diff in this file
##########
File path: tests/python/frontend/onnx/test_forward.py
##########
@@ -4241,9 +4266,9 @@ def verify_cumsum(indata, axis, exclusive=0, reverse=0, type="float32"):
"test_cumsum_2d_negative_axis/",
"test_det_2d/",
"test_det_nd/",
- "test_eyelike_populate_off_main_diagonal/",
- "test_eyelike_with_dtype/",
- "test_eyelike_without_dtype/",
+ # "test_eyelike_populate_off_main_diagonal/",
+ # "test_eyelike_with_dtype/",
+ # "test_eyelike_without_dtype/",
Review comment:
Remove the commented lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on a change in pull request #8191: Onnx eyelike
Posted by GitBox <gi...@apache.org>.
masahi commented on a change in pull request #8191:
URL: https://github.com/apache/tvm/pull/8191#discussion_r645207863
##########
File path: src/driver/driver_api.cc
##########
@@ -185,6 +185,17 @@ IRModule lower(te::Schedule sch, const Array<te::Tensor>& args, const std::strin
return mod;
}
+TVM_REGISTER_GLOBAL("driver.lower").set_body_typed([](te::Schedule sch, const Array<te::Tensor>& args, const String& name, const Map<te::Tensor, tir::Buffer>& binds) {
Review comment:
Remove the diff in this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #8191: Onnx eyelike
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #8191:
URL: https://github.com/apache/tvm/pull/8191#issuecomment-854421897
thanks @CircleSpin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #8191: Onnx eyelike
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #8191:
URL: https://github.com/apache/tvm/pull/8191#issuecomment-854274558
There is still a lint error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #8191: Onnx eyelike
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #8191:
URL: https://github.com/apache/tvm/pull/8191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org