[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2770: add arithmetic and comparison kernels from DF + small modifications

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #2770:
URL: https://github.com/apache/arrow-rs/pull/2770#discussion_r978418843


##########
arrow/src/compute/kernels/arithmetic.rs:
##########
@@ -2898,4 +3060,176 @@ mod tests {
         let division_by_zero = divide_scalar_opt_dyn::<Int32Type>(&a, 0);
         assert_eq!(&expected, &division_by_zero.unwrap());
     }
+
+    // TODO, cast, arithmetic, and comparison all have this function
+    fn create_decimal_array(
+        array: Vec<Option<i128>>,
+        precision: u8,
+        scale: u8,
+    ) -> Result<Decimal128Array> {
+        array
+            .into_iter()
+            .collect::<Decimal128Array>()
+            .with_precision_and_scale(precision, scale)
+    }
+
+    #[test]
+    fn arithmetic_decimal_op_test() -> Result<()> {
+        let value_i128: i128 = 123;
+        let left_decimal_array = create_decimal_array(
+            vec![
+                Some(value_i128),
+                None,
+                Some(value_i128 - 1),
+                Some(value_i128 + 1),
+            ],
+            25,
+            3,
+        )?;
+        let right_decimal_array = create_decimal_array(
+            vec![
+                Some(value_i128),
+                Some(value_i128),
+                Some(value_i128),
+                Some(value_i128),
+            ],
+            25,
+            3,
+        )?;
+        // add
+        let result = add_decimal(&left_decimal_array, &right_decimal_array)?;
+        let expect =
+            create_decimal_array(vec![Some(246), None, Some(245), Some(247)], 25, 3)?;
+        assert_eq!(expect, result);
+        let result = add_decimal_scalar(&left_decimal_array, 10)?;
+        let expect =
+            create_decimal_array(vec![Some(133), None, Some(132), Some(134)], 25, 3)?;
+        assert_eq!(expect, result);
+        // subtract
+        let result = subtract_decimal(&left_decimal_array, &right_decimal_array)?;
+        let expect = create_decimal_array(vec![Some(0), None, Some(-1), Some(1)], 25, 3)?;
+        assert_eq!(expect, result);
+        let result = subtract_decimal_scalar(&left_decimal_array, 10)?;
+        let expect =
+            create_decimal_array(vec![Some(113), None, Some(112), Some(114)], 25, 3)?;
+        assert_eq!(expect, result);
+        // multiply
+        let result = multiply_decimal(&left_decimal_array, &right_decimal_array)?;
+        let expect =
+            create_decimal_array(vec![Some(15), None, Some(15), Some(15)], 25, 3)?;
+        assert_eq!(expect, result);
+        let result = multiply_decimal_scalar(&left_decimal_array, 10)?;
+        let expect = create_decimal_array(vec![Some(1), None, Some(1), Some(1)], 25, 3)?;
+        assert_eq!(expect, result);
+        // divide
+        let left_decimal_array = create_decimal_array(
+            vec![
+                Some(1234567),
+                None,
+                Some(1234567),
+                Some(1234567),
+                Some(1234567),
+            ],
+            25,
+            3,
+        )?;
+        let right_decimal_array = create_decimal_array(
+            vec![Some(10), Some(100), Some(55), Some(-123), None],
+            3,
+            0,
+        )?;
+        let result = divide_opt_decimal(&left_decimal_array, &right_decimal_array)?;
+        let expect = create_decimal_array(
+            vec![Some(123456700), None, Some(22446672), Some(-10037130), None],
+            25,
+            3,
+        )?;
+        assert_eq!(expect, result);
+        let result = divide_decimal_scalar(&left_decimal_array, 10)?;
+        let expect = create_decimal_array(
+            vec![
+                Some(123456700),
+                None,
+                Some(123456700),
+                Some(123456700),
+                Some(123456700),
+            ],
+            25,
+            3,
+        )?;
+        assert_eq!(expect, result);
+        // modulus
+        let result = modulus_decimal(&left_decimal_array, &right_decimal_array)?;
+        let expect =
+            create_decimal_array(vec![Some(7), None, Some(37), Some(16), None], 25, 3)?;
+        assert_eq!(expect, result);
+        let result = modulus_decimal_scalar(&left_decimal_array, 10)?;
+        let expect =
+            create_decimal_array(vec![Some(7), None, Some(7), Some(7), Some(7)], 25, 3)?;
+        assert_eq!(expect, result);
+        Ok(())
+    }
+
+    #[test]
+    fn arithmetic_decimal_divide_by_zero() -> Result<()> {
+        let left_decimal_array = create_decimal_array(vec![Some(101)], 10, 1)?;
+        let right_decimal_array = create_decimal_array(vec![Some(0)], 1, 1)?;
+
+        let err =
+            divide_opt_decimal(&left_decimal_array, &right_decimal_array).unwrap_err();
+        assert_eq!("Divide by zero error", err.to_string());
+        let err = divide_decimal_scalar(&left_decimal_array, 0).unwrap_err();
+        assert_eq!("Divide by zero error", err.to_string());
+        let err = modulus_decimal(&left_decimal_array, &right_decimal_array).unwrap_err();
+        assert_eq!("Divide by zero error", err.to_string());
+        let err = modulus_decimal_scalar(&left_decimal_array, 0).unwrap_err();
+        assert_eq!("Divide by zero error", err.to_string());
+        Ok(())
+    }
+
+    // #[test]

Review Comment:
   Why are these tests commented out, I presume because they aren't working as expected?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org