[GitHub] [apisix] spacewander commented on a change in pull request #4313: feat: nacos discovery support namespace

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #4313:
URL: https://github.com/apache/apisix/pull/4313#discussion_r640276937



##########
File path: t/discovery/nacos.t
##########
@@ -251,3 +251,134 @@ discovery:
 ]
 --- no_error_log
 [error]
+
+
+
+=== TEST 8: get APISIX-NACOS info from NACOS - no auth with namespace

Review comment:
       Need another test that the request gets 503 because the namespace is incorrect.

##########
File path: apisix/schema_def.lua
##########
@@ -389,6 +389,10 @@ local upstream_schema = {
             description = "discovery type",
             type = "string",
         },
+        nacos_namespace_id = {

Review comment:
       I think it would be better if we move the `nacos_namespace_id` into `discovery_args`, like:
   ```
           discovery_args = {
               type = "object",
               properties = {
                   namespace_id = {
                       description = "namespace id",
                       type = "string",
                   },
               }
           },
   ```
   
   This change will make the schema tidy.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org