You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/03 22:31:09 UTC
[GitHub] [beam] robertwb opened a new pull request #11312: [BEAM-9577] Plumb
resources through Python job service and runner.
robertwb opened a new pull request #11312: [BEAM-9577] Plumb resources through Python job service and runner.
URL: https://github.com/apache/beam/pull/11312
Also updates artifact staging service to handle dependencies from
multiple environments.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb commented on a change in pull request #11312:
[BEAM-9577] Plumb resources through Python job service and runner.
Posted by GitBox <gi...@apache.org>.
robertwb commented on a change in pull request #11312: [BEAM-9577] Plumb resources through Python job service and runner.
URL: https://github.com/apache/beam/pull/11312#discussion_r405155788
##########
File path: sdks/python/apache_beam/runners/portability/local_job_service.py
##########
@@ -259,6 +273,7 @@ def run(self):
def _run_job(self):
self.set_state(beam_job_api_pb2.JobState.RUNNING)
with JobLogHandler(self._log_queues):
+ self._update_dependencies()
Review comment:
Yes, in fact the interactive team is looking at improving things here. This particular line is just updating a proto field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on issue #11312: [BEAM-9577] Plumb
resources through Python job service and runner.
Posted by GitBox <gi...@apache.org>.
pabloem commented on issue #11312: [BEAM-9577] Plumb resources through Python job service and runner.
URL: https://github.com/apache/beam/pull/11312#issuecomment-610685322
i was in the neighborhood and figured i'd merge : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on a change in pull request #11312:
[BEAM-9577] Plumb resources through Python job service and runner.
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #11312: [BEAM-9577] Plumb resources through Python job service and runner.
URL: https://github.com/apache/beam/pull/11312#discussion_r403385311
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -716,6 +716,15 @@ def __init__(self,
self.artifact_staging_dir = artifact_staging_dir
self.job_name = job_name
+ def for_environment(self, env):
+ if env.dependencies:
+ provision_info_with_deps = self.provision_info.copy()
+ provision_info_with_deps.dependencies = env.dependencies
+ return ExtendedProvisionInfo(
+ provision_info_with_deps, artifact_staging_dir, job_name)
Review comment:
`self.artifact_staging_dir` and `self.job_name`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem merged pull request #11312: [BEAM-9577] Plumb
resources through Python job service and runner.
Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #11312: [BEAM-9577] Plumb resources through Python job service and runner.
URL: https://github.com/apache/beam/pull/11312
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] pabloem commented on a change in pull request #11312:
[BEAM-9577] Plumb resources through Python job service and runner.
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #11312: [BEAM-9577] Plumb resources through Python job service and runner.
URL: https://github.com/apache/beam/pull/11312#discussion_r404265424
##########
File path: sdks/python/apache_beam/runners/portability/local_job_service.py
##########
@@ -259,6 +273,7 @@ def run(self):
def _run_job(self):
self.set_state(beam_job_api_pb2.JobState.RUNNING)
with JobLogHandler(self._log_queues):
+ self._update_dependencies()
Review comment:
It may be good to log what's going on during job execution? We do something like it in Dataflow, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb commented on a change in pull request #11312:
[BEAM-9577] Plumb resources through Python job service and runner.
Posted by GitBox <gi...@apache.org>.
robertwb commented on a change in pull request #11312: [BEAM-9577] Plumb resources through Python job service and runner.
URL: https://github.com/apache/beam/pull/11312#discussion_r405155765
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -716,6 +716,15 @@ def __init__(self,
self.artifact_staging_dir = artifact_staging_dir
self.job_name = job_name
+ def for_environment(self, env):
+ if env.dependencies:
+ provision_info_with_deps = self.provision_info.copy()
+ provision_info_with_deps.dependencies = env.dependencies
+ return ExtendedProvisionInfo(
+ provision_info_with_deps, artifact_staging_dir, job_name)
Review comment:
Yeah...the tests weren't happy with this either :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb commented on issue #11312: [BEAM-9577] Plumb
resources through Python job service and runner.
Posted by GitBox <gi...@apache.org>.
robertwb commented on issue #11312: [BEAM-9577] Plumb resources through Python job service and runner.
URL: https://github.com/apache/beam/pull/11312#issuecomment-610656236
Thanks. Looks like it needs a rebase due to a conflict, then I'll merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services