[GitHub] [lucene] LuXugang commented on a change in pull request #736: LUCENE-10458: BoundedDocSetIdIterator may supply error count in Weigth#count(LeafReaderContext) when missingValue enables

[GitBox <gi...@apache.org>]

LuXugang commented on a change in pull request #736:
URL: https://github.com/apache/lucene/pull/736#discussion_r826515036



##########
File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortSortedNumericDocValuesRangeQuery.java
##########
@@ -198,16 +198,22 @@ public boolean isCacheable(LeafReaderContext ctx) {
 
       @Override
       public int count(LeafReaderContext context) throws IOException {
-        BoundedDocSetIdIterator disi = getDocIdSetIteratorOrNull(context);
-        if (disi != null) {
-          return disi.lastDoc - disi.firstDoc;
+        Sort indexSort = context.reader().getMetaData().getSort();
+        if (indexSort != null
+            && indexSort.getSort().length > 0
+            && indexSort.getSort()[0].getField().equals(field)
+            && indexSort.getSort()[0].getMissingValue() == null) {

Review comment:
       `indexSort.getSort()[0].getMissingValue() == null`
   It indeed seems too aggressive, Thanks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org