You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Elmahrek <ab...@cloudera.com> on 2015/02/07 00:26:54 UTC
Review Request 30748: Sqoop2: Use common repository constants
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30748/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: sqoop-1994
https://issues.apache.org/jira/browse/sqoop-1994
Repository: sqoop-sqoop2
Description
-------
commit e77bd9fce297d6f0ebf86cafdfbfdfdf59f770e3
Author: Abraham Elmahrek <ab...@apache.org>
Date: Fri Feb 6 14:32:41 2015 -0800
SQOOP-1994: Sqoop2: Use common repository constants
:100644 100644 5ce9488... 6e183de... M repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java
:100644 100644 c991e5c... f7bab09... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 8504091... 7678d35... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
:100644 100644 3740f8d... f54bd22... M repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java
:100644 000000 50c98b7... 0000000... D repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java
:100644 100644 c02ab48... 7e95be1... M repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java
:100644 100644 3e83149... cfbfc36... M repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java
Diffs
-----
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 5ce9488
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java c991e5c
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 8504091
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 3740f8d
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java 50c98b7
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java c02ab48
repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java 3e83149
Diff: https://reviews.apache.org/r/30748/diff/
Testing
-------
mvn test + can start Sqoop server
Thanks,
Abraham Elmahrek
Re: Review Request 30748: Sqoop2: Use common repository constants
Posted by Gwen Shapira <gs...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30748/#review71536
-----------------------------------------------------------
Ship it!
Ship It!
- Gwen Shapira
On Feb. 6, 2015, 11:26 p.m., Abraham Elmahrek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30748/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2015, 11:26 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: sqoop-1994
> https://issues.apache.org/jira/browse/sqoop-1994
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit e77bd9fce297d6f0ebf86cafdfbfdfdf59f770e3
> Author: Abraham Elmahrek <ab...@apache.org>
> Date: Fri Feb 6 14:32:41 2015 -0800
>
> SQOOP-1994: Sqoop2: Use common repository constants
>
> :100644 100644 5ce9488... 6e183de... M repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java
> :100644 100644 c991e5c... f7bab09... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 8504091... 7678d35... M repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
> :100644 100644 3740f8d... f54bd22... M repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java
> :100644 000000 50c98b7... 0000000... D repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java
> :100644 100644 c02ab48... 7e95be1... M repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java
> :100644 100644 3e83149... cfbfc36... M repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java
>
>
> Diffs
> -----
>
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java 5ce9488
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java c991e5c
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java 8504091
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java 3740f8d
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaConstants.java 50c98b7
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaCreateQuery.java c02ab48
> repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaQuery.java 3e83149
>
> Diff: https://reviews.apache.org/r/30748/diff/
>
>
> Testing
> -------
>
> mvn test + can start Sqoop server
>
>
> Thanks,
>
> Abraham Elmahrek
>
>