You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/07 08:39:30 UTC

[GitHub] [airflow] FHoffmannCode opened a new issue #11323: Return files destination uris in all to_ operators

FHoffmannCode opened a new issue #11323:
URL: https://github.com/apache/airflow/issues/11323


   **Description**
   
   Currently some storage operators return files destination uris list for example `GoogleSheetsToGCSOperator`. It would be a good idea to make all of such operators to return this list.
   
   **Use case / motivation**
   
   1. Having list of destination uris for files transferred with operator is useful for debugging and troubleshooting
   2. Inconsistent operator behaviour might be confusing for users.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on issue #11323: Return files destination uris in all to_ operators

Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #11323:
URL: https://github.com/apache/airflow/issues/11323#issuecomment-1030826796


   It depends on what are correctly being returned; I’m assuming most (if not all) are currently returning None, which won’t have backward compatibility issues (except if someone is depending on an XCom is _not_ pushed, but why would anyone do that). Are there instances of an operator currently pushing something else?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #11323: Return files destination uris in all to_ operators

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #11323:
URL: https://github.com/apache/airflow/issues/11323#issuecomment-1014363539


   This issue spawn from https://github.com/apache/airflow/pull/10991#discussion_r500837769
   It probably can be useful but it's also a breaking change and so far I didn't see users complaining about it.
   Could you please clarify the TODO part on this issue?
   What operators need adjustments? Is it localized to GCP or also other providers?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on issue #11323: Return files destination uris in all to_ operators

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11323:
URL: https://github.com/apache/airflow/issues/11323#issuecomment-1062414814


   This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further activity occurs from the issue author.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #11323: Return files destination uris in all to_ operators

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #11323:
URL: https://github.com/apache/airflow/issues/11323#issuecomment-1030820627


   > Yeah I don’t see how this could break user code in practice.
   
   The suggestion was to change the returned value to make operators consistent. If changed then the value pushed to xcom is not as users are expecting.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #11323: Return files destination uris in all to_ operators

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #11323:
URL: https://github.com/apache/airflow/issues/11323#issuecomment-1030914862


   Yeah. Same here. I think it's no harm to return "more".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #11323: Return files destination uris in all to_ operators

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #11323:
URL: https://github.com/apache/airflow/issues/11323#issuecomment-1030801904


   Yeah. Nice feature to add. Would you like to implement it @FHoffmannCode ? Should I assign it to you ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on issue #11323: Return files destination uris in all to_ operators

Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #11323:
URL: https://github.com/apache/airflow/issues/11323#issuecomment-1022901342


   Yeah I don’t see how this could break user code in practice. Should be doable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #11323: Return files destination uris in all to_ operators

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #11323:
URL: https://github.com/apache/airflow/issues/11323#issuecomment-704785662


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org