You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ah...@apache.org on 2017/04/21 02:37:11 UTC
flex-typedefs git commit: nevermind,
it had impact on downstream swcs. Node's AssertError extends Error
and adds its own toString(). We'll fix in the compiler
Repository: flex-typedefs
Updated Branches:
refs/heads/develop 59b733346 -> 8c617b873
nevermind, it had impact on downstream swcs. Node's AssertError extends Error and adds its own toString(). We'll fix in the compiler
Project: http://git-wip-us.apache.org/repos/asf/flex-typedefs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-typedefs/commit/8c617b87
Tree: http://git-wip-us.apache.org/repos/asf/flex-typedefs/tree/8c617b87
Diff: http://git-wip-us.apache.org/repos/asf/flex-typedefs/diff/8c617b87
Branch: refs/heads/develop
Commit: 8c617b873da5c0d84bc296f58ba55dfdf2fcfc12
Parents: 59b7333
Author: Alex Harui <ah...@apache.org>
Authored: Thu Apr 20 19:37:12 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Thu Apr 20 19:37:12 2017 -0700
----------------------------------------------------------------------
js/src/main/config/externc-config.xml | 4 ++--
js/src/main/javascript/missing.js | 11 -----------
2 files changed, 2 insertions(+), 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-typedefs/blob/8c617b87/js/src/main/config/externc-config.xml
----------------------------------------------------------------------
diff --git a/js/src/main/config/externc-config.xml b/js/src/main/config/externc-config.xml
index 5935881..673b656 100644
--- a/js/src/main/config/externc-config.xml
+++ b/js/src/main/config/externc-config.xml
@@ -139,8 +139,8 @@
</class-exclude>
<!-- Object.toString() is excluded by the ExternC compiler. Otherwise
- int.toString(radix) becomes an illegal override. Other classes
- need to have their toString() supplied by missing.js -->
+ int.toString(radix) becomes an illegal override. The compiler should
+ allow toString() usage in every object -->
<exclude>
<class>Array</class>
<name>toSource</name>
http://git-wip-us.apache.org/repos/asf/flex-typedefs/blob/8c617b87/js/src/main/javascript/missing.js
----------------------------------------------------------------------
diff --git a/js/src/main/javascript/missing.js b/js/src/main/javascript/missing.js
index fb467c7..93dc092 100644
--- a/js/src/main/javascript/missing.js
+++ b/js/src/main/javascript/missing.js
@@ -262,14 +262,3 @@ uint.MAX_VALUE;
* @const
*/
uint.MIN_VALUE;
-
-
-/**
- * Many top-level classes will need a toString() defined.
- * Object.toString() is excluded by the ExternC compiler
- * so int.toString(radix) doesn't return an illegal override
- * error.
- * @return {string} The result.
- */
-Error.prototype.toString = function() {}
-