You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@apache.org> on 2018/09/21 10:38:30 UTC

Re: Use existing __ namespace in public headers for experimental APIs to unblock 1.11 release

Julian Foad wrote:
> One important thing I didn't make clear: I propose these APIs go in 
> "public" headers like svn_client.h, not in the "private" header files 
> that are by default omitted from installation.

Or rather, to be honest, I hadn't thought it through at the point where I sent this proposal, but now have been thinking and discussing it with others on IRC. I should not have used the word "hide" and have now changed the email subject line. The key thing was we needed to move them out of the strong compatibility rules, and using the existing "__" namespace is sufficient for that.

- Julian


> Stefan, does this make a difference to you? Do you still need to change 
> TSVN build scripts at all for that case? And how will the warnings work 
> out for you in that case? I'd really like to hear how this affects you 
> so we can come to a satisfactory solution.

Re: Use existing __ namespace in public headers for experimental APIs to unblock 1.11 release

Posted by Julian Foad <ju...@apache.org>.
Julian Foad wrote:
> Julian Foad wrote:
> > > One important thing I didn't make clear: I propose these APIs go in 
> > > "public" headers like svn_client.h, not in the "private" header files 
> > > that are by default omitted from installation.
> 
> There's a nomination in the STATUS file for this change, now.
> 
> Can anyone please review or otherwise comment on it?

It's approved and backported now. Thanks, Brane and Bert.

The 1.11 release is unblocked.


> > [...] The key thing was we needed to move them 
> > out of the strong compatibility rules, and using the existing "__" 
> > namespace is sufficient for that.
> > 
> > > Stefan, does this make a difference to you? Do you still need to change 
> > > TSVN build scripts at all for that case? And how will the warnings work 
> > > out for you in that case? I'd really like to hear how this affects you 
> > > so we can come to a satisfactory solution.

-- 
- Julian

Re: Use existing __ namespace in public headers for experimental APIs to unblock 1.11 release

Posted by Julian Foad <ju...@apache.org>.
Julian Foad wrote:
> > One important thing I didn't make clear: I propose these APIs go in 
> > "public" headers like svn_client.h, not in the "private" header files 
> > that are by default omitted from installation.

There's a nomination in the STATUS file for this change, now.

Can anyone please review or otherwise comment on it?


> [...] The key thing was we needed to move them 
> out of the strong compatibility rules, and using the existing "__" 
> namespace is sufficient for that.
> 
> > Stefan, does this make a difference to you? Do you still need to change 
> > TSVN build scripts at all for that case? And how will the warnings work 
> > out for you in that case? I'd really like to hear how this affects you 
> > so we can come to a satisfactory solution.

-- 
- Julian