[GitHub] [dolphinscheduler] kyoty commented on a change in pull request #5632: [Improvement][SQL] Query return number In SQL should be configurable

[GitBox <gi...@apache.org>]

kyoty commented on a change in pull request #5632:
URL: https://github.com/apache/dolphinscheduler/pull/5632#discussion_r651960069



##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/sql.vue
##########
@@ -43,6 +43,13 @@
         </div>
       </div>
     </m-list-box>
+    <m-list-box>
+        <div slot="text"><strong class='requiredIcon'>*</strong>{{$t('Max Numbers Return')}}</div>
+        <div slot="content">
+          <el-input type="input" :disabled="isDetails" size="medium" v-model="limit" :placeholder="$t('Max Numbers Return placeholder')">
+          </el-input>
+        </div>
+    </m-list-box>

Review comment:
       @zhuangchong Thanks for youre review.
   Sorry I forget to merge some code. I have updated by add a condition `<m-list-box v-show="sqlType === '0'">`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org