You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Hui Fei (Jira)" <ji...@apache.org> on 2021/09/20 15:32:00 UTC

[jira] [Commented] (HDFS-16231) Fix TestDataNodeMetrics#testReceivePacketSlowMetrics

    [ https://issues.apache.org/jira/browse/HDFS-16231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17417695#comment-17417695 ] 

Hui Fei commented on HDFS-16231:
--------------------------------

[~haiyang Hu] Thanks for reporting this. Looking forward to your patch :)

> Fix TestDataNodeMetrics#testReceivePacketSlowMetrics
> ----------------------------------------------------
>
>                 Key: HDFS-16231
>                 URL: https://issues.apache.org/jira/browse/HDFS-16231
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Haiyang Hu
>            Assignee: Haiyang Hu
>            Priority: Major
>
> TestDataNodeMetrics#testReceivePacketSlowMetrics fails with stacktrace:
> {code:java}
> java.lang.AssertionError: Expected exactly one metric for name TotalPacketsReceived 
> Expected :1
> Actual   :0
>  <Click to see difference>
> 	at org.junit.Assert.fail(Assert.java:89)
> 	at org.junit.Assert.failNotEquals(Assert.java:835)
> 	at org.junit.Assert.assertEquals(Assert.java:647)
> 	at org.apache.hadoop.test.MetricsAsserts.checkCaptured(MetricsAsserts.java:278)
> 	at org.apache.hadoop.test.MetricsAsserts.getLongCounter(MetricsAsserts.java:237)
> 	at org.apache.hadoop.hdfs.server.datanode.TestDataNodeMetrics.testReceivePacketSlowMetrics(TestDataNodeMetrics.java:200)
> {code}
> {code:java}
> // Error MetricsName in current code,e.g TotalPacketsReceived,TotalPacketsSlowWriteToMirror,TotalPacketsSlowWriteToDisk,TotalPacketsSlowWriteToOsCache
>       MetricsRecordBuilder dnMetrics = getMetrics(datanode.getMetrics().name());
>       assertTrue("More than 1 packet received",
>           getLongCounter("TotalPacketsReceived", dnMetrics) > 1L); 
>       assertTrue("More than 1 slow packet to mirror",
>           getLongCounter("TotalPacketsSlowWriteToMirror", dnMetrics) > 1L);
>       assertCounter("TotalPacketsSlowWriteToDisk", 1L, dnMetrics);
>       assertCounter("TotalPacketsSlowWriteToOsCache", 0L, dnMetrics);
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org