[jira] Commented: (OFBIZ-2848) Add PartyIdentification feature

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752139#action_12752139 ] 

Jacques Le Roux commented on OFBIZ-2848:
----------------------------------------

Hi Nicolas,

1st : review, remarks :
# please don't put .project file in your patch,
# add Permission Check to your service declarations, something like
{code}
<permission-service service-name="partyBasePermissionCheck" main-action="........"/>
{code}
# I'd prefer n° than numéro in french l10n, that's subjective, I used n° everywhere else in OFBiz.

Else looks pretty good, thanks.

> Add PartyIdentification feature
> -------------------------------
>
>                 Key: OFBIZ-2848
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2848
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: SVN trunk
>            Reporter: nicolas malin
>             Fix For: SVN trunk
>
>         Attachments: partyIdentification.patch
>
>   Original Estimate: 0.5h
>  Remaining Estimate: 0.5h
>
> Add PartyIdentification entity for management identification number associate to a party as goodIdentification for product.
> This issue contains :
>  * entities 
>  * portlet added to profile party screen
>  * demo data
>  * edit and list PartyIdentification screen
>  * search service to find a Party by an Id (partyId or idValue associate)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.