You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/11 18:02:35 UTC

[GitHub] [beam] Abacn opened a new pull request, #22223: Remove deprecated unused option in seed job script

Abacn opened a new pull request, #22223:
URL: https://github.com/apache/beam/pull/22223

   Fixes #22184
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm merged pull request #22223: Remove deprecated unused option in seed job script

Posted by GitBox <gi...@apache.org>.
damccorm merged PR #22223:
URL: https://github.com/apache/beam/pull/22223


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #22223: Remove deprecated unused option in seed job script

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22223:
URL: https://github.com/apache/beam/pull/22223#issuecomment-1180708238

   R: @damccorm 
   
   Needs Committer to run seed job. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #22223: Remove deprecated unused option in seed job script

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22223:
URL: https://github.com/apache/beam/pull/22223#issuecomment-1180730364

   Run Spotless PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #22223: Remove deprecated unused option in seed job script

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22223:
URL: https://github.com/apache/beam/pull/22223#issuecomment-1180742049

   (Borrowed this PR to see the change of #22203 after seedjob successfully run. As expected the checkStyle Tab appears: https://ci-beam.apache.org/job/beam_PreCommit_Spotless_Phrase/140/checkstyle/ )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #22223: Remove deprecated unused option in seed job script

Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #22223:
URL: https://github.com/apache/beam/pull/22223#discussion_r918257991


##########
.test-infra/jenkins/committers_list_generator/main.py:
##########
@@ -63,7 +63,6 @@ def get_committers_github_usernames(ldap_uris, cert_path):
     connection = None
     try:
         ldap.set_option(ldap.OPT_X_TLS_CACERTFILE, cert_path)
-        ldap.set_option(ldap.OPT_X_TLS, ldap.OPT_X_TLS_DEMAND)

Review Comment:
   Ah, I see - so now it should be inferred and we don't need the explicit option (and it throws). Thanks for the context, just wanted to make sure we weren't losing something we'd need to replace



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #22223: Remove deprecated unused option in seed job script

Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #22223:
URL: https://github.com/apache/beam/pull/22223#issuecomment-1180706043

   R: @ahmedabu98


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on a diff in pull request #22223: Remove deprecated unused option in seed job script

Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #22223:
URL: https://github.com/apache/beam/pull/22223#discussion_r918219369


##########
.test-infra/jenkins/committers_list_generator/main.py:
##########
@@ -63,7 +63,6 @@ def get_committers_github_usernames(ldap_uris, cert_path):
     connection = None
     try:
         ldap.set_option(ldap.OPT_X_TLS_CACERTFILE, cert_path)
-        ldap.set_option(ldap.OPT_X_TLS, ldap.OPT_X_TLS_DEMAND)

Review Comment:
   What was this trying to do before?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on a diff in pull request #22223: Remove deprecated unused option in seed job script

Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #22223:
URL: https://github.com/apache/beam/pull/22223#discussion_r918229860


##########
.test-infra/jenkins/committers_list_generator/main.py:
##########
@@ -63,7 +63,6 @@ def get_committers_github_usernames(ldap_uris, cert_path):
     connection = None
     try:
         ldap.set_option(ldap.OPT_X_TLS_CACERTFILE, cert_path)
-        ldap.set_option(ldap.OPT_X_TLS, ldap.OPT_X_TLS_DEMAND)

Review Comment:
   According to this https://github.com/python-ldap/python-ldap/issues/67 "OPT_X_TLS is deprecated and no longer documented in OpenLDAP: https://www.openldap.org/lists/openldap-software/200409/msg00617.html" (which says "This ldap_set_option(LDAP_OPT_X_TLS) feature is used to explicitly establish an ldaps session. The use of ldaps comes from LDAP version 2 and is deprecated;")
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org