[GitHub] [hive] zabetak commented on pull request #2432: HIVE-24590: Operation logging still leaks log4j appenders

[GitBox <gi...@apache.org>]

zabetak commented on pull request #2432:
URL: https://github.com/apache/hive/pull/2432#issuecomment-872010471


   Hi @prasanthj , following your last comment on https://github.com/apache/hive/pull/1849 I added Hive property to control the lifespan of appenders in https://github.com/apache/hive/pull/2432/commits/bc683ec2d6959e5aba7d216abcd060a07e854d46. 
   
   Ideally the whole programmatic registration of the appender should be replaced by `log4j.properties` or other more standard mechanism but this is a bit more complicated to do so I would leave it outside the scope of this PR. 
   
   All the tests are green, so if you can have a final look and merge it that would be great since apparently more people are hitting this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org