[GitHub] [druid] clintropolis commented on a change in pull request #11280: bitwise aggregators, better null handling options for expression agg

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #11280:
URL: https://github.com/apache/druid/pull/11280#discussion_r656997310



##########
File path: core/src/main/java/org/apache/druid/math/expr/ExprEval.java
##########
@@ -48,7 +49,7 @@
   public static ExprEval deserialize(ByteBuffer buffer, int position)
   {
     // | expression type (byte) | expression bytes |
-    ExprType type = ExprType.fromByte(buffer.get(position));
+    ExprType type = ExprType.fromByte((byte) (buffer.get(position) & TYPE_MASK));

Review comment:
       I reworked this to do the masking in the buffer aggregator instead of here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org