[GitHub] [spark] srowen commented on a change in pull request #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource.

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24647: [SPARK-27776][SQL]Avoid duplicate Java reflection in DataSource.
URL: https://github.com/apache/spark/pull/24647#discussion_r286461989
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
 ##########
 @@ -105,6 +105,8 @@ case class DataSource(
       case _ => cls
     }
   }
+  private def providingInstance = providingClass.getConstructor().newInstance()
 
 Review comment:
   This should be declared like a method for clarity, with a return type. Also add a new line above. I'd use `()` in the declaration and invocations for clarity too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org