[PR] [MPLUGIN-512] Do not compute a goal prefix from an artifactId that is too short [maven-plugin-tools]

["slachiewicz (via GitHub)" <gi...@apache.org>]

slachiewicz opened a new pull request, #1201:
URL: https://github.com/apache/maven-plugin-tools/pull/1201

   `getDefaultGoalPrefix` strips `maven-` and `-plugin` without checking that anything is left between them, so an artifactId such as `maven-plugin` computes `substring(6, 5)` and the `descriptor` goal fails with `StringIndexOutOfBoundsException: Range [6, 5) out of bounds for length 12` instead of the intended "You need to specify a goalPrefix" error. Fixes #831.
   
   Verified: the four added cases in `DescriptorGeneratorMojoTest` reproduce the exception on the unpatched code (2 failures, 1 error) and pass with the fix; `mvn verify -pl maven-plugin-plugin` green.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [MPLUGIN-512] Do not compute a goal prefix from an artifactId that is too short [maven-plugin-tools]

["slachiewicz (via GitHub)" <gi...@apache.org>]

slachiewicz merged PR #1201:
URL: https://github.com/apache/maven-plugin-tools/pull/1201


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org