You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/06 02:12:40 UTC
[GitHub] [skywalking-cli] JarvisG495 opened a new pull request #113: Add the sub-command 'service' of command 'dependency'
JarvisG495 opened a new pull request #113:
URL: https://github.com/apache/skywalking-cli/pull/113
swctl dependency service [service-id] [--start=start-time] [--end=end-time]
Query the dependencies of a given service and show results in JSON format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] JarvisG495 commented on pull request #113: Add the sub-command 'service' of command 'dependency'
Posted by GitBox <gi...@apache.org>.
JarvisG495 commented on pull request #113:
URL: https://github.com/apache/skywalking-cli/pull/113#issuecomment-913418263
> Well, seems you changed the file mode, it's now not executable
>
> <img alt="Screen Shot 2021-09-06 at 15 27 20" width="544" src="https://user-images.githubusercontent.com/15965696/132177055-4046ac8c-2b99-4717-8b99-160fd0d18e38.png">
Sry I made a mistake in my developing environment. I made a new commit to change the file mode back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] wu-sheng commented on pull request #113: Add the sub-command 'service' of command 'dependency'
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #113:
URL: https://github.com/apache/skywalking-cli/pull/113#issuecomment-913293284
FYI @mrproliu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] fgksgf commented on a change in pull request #113: Add the sub-command 'service' of command 'dependency'
Posted by GitBox <gi...@apache.org>.
fgksgf commented on a change in pull request #113:
URL: https://github.com/apache/skywalking-cli/pull/113#discussion_r702624147
##########
File path: internal/commands/dependency/service.go
##########
@@ -0,0 +1,74 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package dependency
+
+import (
+ "fmt"
+
+ "github.com/urfave/cli"
+
+ "github.com/apache/skywalking-cli/internal/commands/interceptor"
+ "github.com/apache/skywalking-cli/internal/flags"
+ "github.com/apache/skywalking-cli/internal/logger"
+ "github.com/apache/skywalking-cli/internal/model"
+
+ "github.com/apache/skywalking-cli/pkg/display"
+ "github.com/apache/skywalking-cli/pkg/display/displayable"
+
+ "github.com/apache/skywalking-cli/pkg/graphql/dependency"
+
+ api "skywalking.apache.org/repo/goapi/query"
+)
+
+var ServiceCommand = cli.Command{
+ Name: "service",
+ ShortName: "sv",
Review comment:
```suggestion
ShortName: "svc",
```
##########
File path: README.md
##########
@@ -564,6 +564,22 @@ You can imitate the content of [the default template file](examples/global.yml)
### `dependency`
+#### `service`
+
+<details>
+
+<summary>dependency service [service-id] [--start=start-time] [--end=end-time]</summary>
Review comment:
```suggestion
<summary>dependency service <service-id> [--start=start-time] [--end=end-time]</summary>
```
##########
File path: README.md
##########
@@ -564,6 +564,22 @@ You can imitate the content of [the default template file](examples/global.yml)
### `dependency`
+#### `service`
+
+<details>
+
+<summary>dependency service [service-id] [--start=start-time] [--end=end-time]</summary>
Review comment:
It should be required instead of optional.
##########
File path: internal/commands/dependency/service.go
##########
@@ -0,0 +1,74 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package dependency
+
+import (
+ "fmt"
+
+ "github.com/urfave/cli"
+
+ "github.com/apache/skywalking-cli/internal/commands/interceptor"
+ "github.com/apache/skywalking-cli/internal/flags"
+ "github.com/apache/skywalking-cli/internal/logger"
+ "github.com/apache/skywalking-cli/internal/model"
+
+ "github.com/apache/skywalking-cli/pkg/display"
+ "github.com/apache/skywalking-cli/pkg/display/displayable"
+
+ "github.com/apache/skywalking-cli/pkg/graphql/dependency"
+
+ api "skywalking.apache.org/repo/goapi/query"
+)
+
+var ServiceCommand = cli.Command{
+ Name: "service",
+ ShortName: "sv",
Review comment:
`svc` would be more common.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] kezhenxu94 commented on pull request #113: Add the sub-command 'service' of command 'dependency'
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #113:
URL: https://github.com/apache/skywalking-cli/pull/113#issuecomment-913412290
Well, seems you changed the file mode, it's now not executable
<img width="544" alt="Screen Shot 2021-09-06 at 15 27 20" src="https://user-images.githubusercontent.com/15965696/132177055-4046ac8c-2b99-4717-8b99-160fd0d18e38.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] kezhenxu94 merged pull request #113: Add the sub-command 'service' of command 'dependency'
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #113:
URL: https://github.com/apache/skywalking-cli/pull/113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] JarvisG495 commented on pull request #113: Add the sub-command 'service' of command 'dependency'
Posted by GitBox <gi...@apache.org>.
JarvisG495 commented on pull request #113:
URL: https://github.com/apache/skywalking-cli/pull/113#issuecomment-913409894
> Thank you @JarvisG495 , maybe add the command to https://github.com/apache/skywalking-cli/blob/master/scripts/test_commands.sh as well? Just for sanity check
Sure. I have added it in my new commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org