You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "David M. Lee (JIRA)" <ji...@codehaus.org> on 2009/10/21 15:31:26 UTC

[jira] Created: (MRELEASE-494) Should fail during release:prepare if scm:url doesn't match working copy

Should fail during release:prepare if scm:url doesn't match working copy
------------------------------------------------------------------------

                 Key: MRELEASE-494
                 URL: http://jira.codehaus.org/browse/MRELEASE-494
             Project: Maven 2.x Release Plugin
          Issue Type: Bug
          Components: prepare
    Affects Versions: 2.0-beta-9
         Environment: Subversion SCM; working in a branch
            Reporter: David M. Lee


The release plugin should check scm:url against the output of {{svn info}}.  If they don't match, it should fail with an error.

We had a situation where the pom file in a branch was screwed up during a merge, such that scm:url was incorrect.  In our case, it pointed to the trunk instead of the branch.

This caused release:prepare to silently do the wrong thing.  It would still do the normal edit/commit in the working copy of the branch, but then it would do the copy using the scm:url.  In our case, this meant that the tag was copied from the trunk instead of the branch.

In fact, release:perform also completed successfully; our only indication that there was a problem was the version number of the released artifacts.

We cannot set remotetagging=false due to the Subversion bug trying to copy with svn > 1.5.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MRELEASE-494) Should fail during release:prepare if scm:url doesn't match working copy

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRELEASE-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter closed MRELEASE-494.
---------------------------------

    Resolution: Duplicate
      Assignee: Brett Porter

> Should fail during release:prepare if scm:url doesn't match working copy
> ------------------------------------------------------------------------
>
>                 Key: MRELEASE-494
>                 URL: http://jira.codehaus.org/browse/MRELEASE-494
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: prepare
>    Affects Versions: 2.0-beta-9
>         Environment: Subversion SCM; working in a branch
>            Reporter: David M. Lee
>            Assignee: Brett Porter
>
> The release plugin should check scm:url against the output of {{svn info}}.  If they don't match, it should fail with an error.
> We had a situation where the pom file in a branch was screwed up during a merge, such that scm:url was incorrect.  In our case, it pointed to the trunk instead of the branch.
> This caused release:prepare to silently do the wrong thing.  It would still do the normal edit/commit in the working copy of the branch, but then it would do the copy using the scm:url.  In our case, this meant that the tag was copied from the trunk instead of the branch.
> In fact, release:perform also completed successfully; our only indication that there was a problem was the version number of the released artifacts.
> We cannot set remotetagging=false due to the Subversion bug trying to copy with svn > 1.5.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (MRELEASE-494) Should fail during release:prepare if scm:url doesn't match working copy

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRELEASE-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter reopened MRELEASE-494:
-----------------------------------

      Assignee:     (was: Brett Porter)

> Should fail during release:prepare if scm:url doesn't match working copy
> ------------------------------------------------------------------------
>
>                 Key: MRELEASE-494
>                 URL: http://jira.codehaus.org/browse/MRELEASE-494
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: prepare
>    Affects Versions: 2.0-beta-9
>         Environment: Subversion SCM; working in a branch
>            Reporter: David M. Lee
>
> The release plugin should check scm:url against the output of {{svn info}}.  If they don't match, it should fail with an error.
> We had a situation where the pom file in a branch was screwed up during a merge, such that scm:url was incorrect.  In our case, it pointed to the trunk instead of the branch.
> This caused release:prepare to silently do the wrong thing.  It would still do the normal edit/commit in the working copy of the branch, but then it would do the copy using the scm:url.  In our case, this meant that the tag was copied from the trunk instead of the branch.
> In fact, release:perform also completed successfully; our only indication that there was a problem was the version number of the released artifacts.
> We cannot set remotetagging=false due to the Subversion bug trying to copy with svn > 1.5.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MRELEASE-494) Should fail during release:prepare if scm:url doesn't match working copy

Posted by "Martin Todorov (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MRELEASE-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=302608#comment-302608 ] 

Martin Todorov commented on MRELEASE-494:
-----------------------------------------

Older versions of the plugin (ca. 2.1.x?) had a bug where the scm:url was getting messed up and when rolling back this would mess things up and keep an incorrect scm url.
Another case where this can happen is when developers have created a branch off a tag (manually) and have forgotten to change the scm url-s. This would be an excellent thing to check for!

                
> Should fail during release:prepare if scm:url doesn't match working copy
> ------------------------------------------------------------------------
>
>                 Key: MRELEASE-494
>                 URL: https://jira.codehaus.org/browse/MRELEASE-494
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: prepare
>    Affects Versions: 2.0-beta-9
>         Environment: Subversion SCM; working in a branch
>            Reporter: David M. Lee
>
> The release plugin should check scm:url against the output of {{svn info}}.  If they don't match, it should fail with an error.
> We had a situation where the pom file in a branch was screwed up during a merge, such that scm:url was incorrect.  In our case, it pointed to the trunk instead of the branch.
> This caused release:prepare to silently do the wrong thing.  It would still do the normal edit/commit in the working copy of the branch, but then it would do the copy using the scm:url.  In our case, this meant that the tag was copied from the trunk instead of the branch.
> In fact, release:perform also completed successfully; our only indication that there was a problem was the version number of the released artifacts.
> We cannot set remotetagging=false due to the Subversion bug trying to copy with svn > 1.5.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRELEASE-494) Should fail during release:prepare if scm:url doesn't match working copy

Posted by "Phillip Hellewell (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRELEASE-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=240328#action_240328 ] 

Phillip Hellewell commented on MRELEASE-494:
--------------------------------------------

An scm:validate might be ok, but you have to watch out for SVN which may have different URLs that go to the same place (e.g., "svn+ssh://..." and "http://...").

> Should fail during release:prepare if scm:url doesn't match working copy
> ------------------------------------------------------------------------
>
>                 Key: MRELEASE-494
>                 URL: http://jira.codehaus.org/browse/MRELEASE-494
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: prepare
>    Affects Versions: 2.0-beta-9
>         Environment: Subversion SCM; working in a branch
>            Reporter: David M. Lee
>
> The release plugin should check scm:url against the output of {{svn info}}.  If they don't match, it should fail with an error.
> We had a situation where the pom file in a branch was screwed up during a merge, such that scm:url was incorrect.  In our case, it pointed to the trunk instead of the branch.
> This caused release:prepare to silently do the wrong thing.  It would still do the normal edit/commit in the working copy of the branch, but then it would do the copy using the scm:url.  In our case, this meant that the tag was copied from the trunk instead of the branch.
> In fact, release:perform also completed successfully; our only indication that there was a problem was the version number of the released artifacts.
> We cannot set remotetagging=false due to the Subversion bug trying to copy with svn > 1.5.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira