Re: [PR] [Bug](Compaction): fix compact version miss when too many invisible version [doris]

["Userwhite (via GitHub)" <gi...@apache.org>]

Userwhite commented on code in PR #49771:
URL: https://github.com/apache/doris/pull/49771#discussion_r2464819665


##########
be/src/olap/tablet.cpp:
##########
@@ -1296,8 +1296,8 @@ std::vector<RowsetSharedPtr> Tablet::_pick_visible_rowsets_to_compaction(
             // 1. had been visible;
             // 2. exceeds the limit of keep invisible versions.
             int64_t version_end = version.second;
-            if (version_end <= visible_version ||
-                version_end > visible_version + keep_invisible_version_limit) {
+            if (version_end <= visible_version || ((candidate_rowsets.empty() || candidate_rowsets.front()->version().second > visible_version) 

Review Comment:
   ok, i'll fix it
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org