You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/21 22:48:23 UTC
[GitHub] [incubator-yunikorn-k8shim] craigcondit opened a new pull request #393: [YUNIKORN-1119] Rotate TLS certificates in admission controller
craigcondit opened a new pull request #393:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/393
### What is this PR for?
Auto-rotates TLS certificates used by the admission controller webhook. When certs are within 30 days of expiration, new certs will be generated and the internal http server will be restarted. The restart process takes approximately 1-2 ms.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1119
### How should this be tested?
Basic runtime functionality is covered by E2E tests. Rotation verified by sending process SIGUSR1 during execution, which is an alternate method to trigger new certs to be generated.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s closed pull request #393: [YUNIKORN-1119] Rotate TLS certificates in admission controller
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #393:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #393: [YUNIKORN-1119] Rotate TLS certificates in admission controller
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #393:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/393#issuecomment-1074501930
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/393?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#393](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/393?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea668bc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/1fbf8c2a115a5d67ef2fe141a4303fa511abbce4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1fbf8c2) will **decrease** coverage by `0.52%`.
> The diff coverage is `1.20%`.
```diff
@@ Coverage Diff @@
## master #393 +/- ##
==========================================
- Coverage 65.64% 65.12% -0.53%
==========================================
Files 40 40
Lines 6241 6291 +50
==========================================
Hits 4097 4097
- Misses 1985 2034 +49
- Partials 159 160 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/393?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/plugin/admissioncontrollers/webhook/webhook.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/393/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL3dlYmhvb2suZ28=) | `0.00% <0.00%> (ø)` | |
| [...in/admissioncontrollers/webhook/webhook\_manager.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/393/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL3dlYmhvb2tfbWFuYWdlci5nbw==) | `76.50% <9.09%> (-1.38%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/393?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/393?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1fbf8c2...ea668bc](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/393?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org