[GitHub] [lucene-solr] atris commented on a change in pull request #897: LUCENE-8978: Maximal Of Minimum Scores Based Concurrent Early Termination

[GitBox <gi...@apache.org>]

atris commented on a change in pull request #897: LUCENE-8978: Maximal Of Minimum Scores Based Concurrent Early Termination
URL: https://github.com/apache/lucene-solr/pull/897#discussion_r327473718
 
 

 ##########
 File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
 ##########
 @@ -276,7 +283,20 @@ protected void updateMinCompetitiveScore(Scorable scorer) throws IOException {
           && pqTop.score != Float.NEGATIVE_INFINITY) { // -Infinity is the score of sentinels
       // since we tie-break on doc id and collect in doc id order, we can require
       // the next float
-      scorer.setMinCompetitiveScore(Math.nextUp(pqTop.score));
 
 Review comment:
   Good idea -- I was toying around with the same (in fact, the first iteration of the original PR had that, but then I removed it since I was not sure). Updated now, thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org