[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #1311: HDDS-1946. CertificateClient should not persist keys/certs to ozone.m…

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #1311: HDDS-1946. CertificateClient should not persist keys/certs to ozone.m…
URL: https://github.com/apache/hadoop/pull/1311#discussion_r314968409
 
 

 ##########
 File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/x509/certificate/client/DNCertificateClient.java
 ##########
 @@ -25,20 +25,26 @@
 import org.slf4j.LoggerFactory;
 
 import org.apache.hadoop.hdds.security.x509.SecurityConfig;
+
+import java.nio.file.Paths;
+
 /**
  * Certificate client for DataNodes.
  */
 public class DNCertificateClient extends DefaultCertificateClient {
 
   private static final Logger LOG =
       LoggerFactory.getLogger(DNCertificateClient.class);
+
+  public static final String COMPONENT_NAME = Paths.get("dn").toString();
 
 Review comment:
   Minor NIT: Here we can use directly assign the component name, instead of calling Paths.get("dn").toString(). As this also just returns "dn".
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org