You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "uyivzola (via GitHub)" <gi...@apache.org> on 2026/09/09 23:01:42 UTC

[PR] fix(boxplot): preserve null grouping values [superset]

uyivzola opened a new pull request, #44122:
URL: https://github.com/apache/superset/pull/44122

   ### SUMMARY
   
   Preserve NULL grouping values in box plots so their observations contribute to the displayed distributions. Adds regression coverage for statistics, labels, tooltips, and filters. Addresses the box-plot portion of #43547.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before: NULL groups disappear; an all-NULL grouping column shows no results.
   
   ![Before](https://github.com/user-attachments/assets/a51b10b5-57b3-4ea8-b8b5-0a40f2485821)
   
   After: the missing boxes and their statistics appear with `<NULL>` labels.
   
   ![After](https://github.com/user-attachments/assets/d4d6b74a-553b-4130-a089-bf1e30b722b8)
   
   ### TESTING INSTRUCTIONS
   
   Create a box plot with mixed NULL/non-NULL groups. Repeat with all groups NULL, two grouping columns, and each whisker mode.
   
   Passed: 151 backend tests, 15 box-plot frontend tests, pre-commit (mypy and TypeScript included), and the production docs build. Nine live chart API cases and browser rendering passed with the exact changed backend module in an existing ARM64 Superset image.
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: #43547 (box plots only)
   - [x] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(boxplot): preserve null grouping values [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44122:
URL: https://github.com/apache/superset/pull/44122#issuecomment-5609931487

   ### <span aria-hidden="true">βœ…</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">πŸ”¨</span> Latest commit | 764d0105832f6091d70c97dad8caafc6efa185e8 |
   |<span aria-hidden="true">πŸ”</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6aa1e5577587b50008e034e9 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-44122--superset-docs-preview.netlify.app](https://deploy-preview-44122--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">πŸ“±</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQ0MTIyLS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.iQlA8HeTcT7j1OwLwopczl9xF75Yr-Qlz8xA9ItfQ3w)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">πŸ€–</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DYtbCoAgEADvst9JRm5WN-gYmtsDrBUzMKK7598wzLwQIh8hwQhQgY3mnLfCMzvK9bJnoVpUWljOwXMS5-29WCPf4Sq5oyKfyZWhM6YhRK2x1xallD3JVtEA3w8) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-44122--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(boxplot): preserve null grouping values [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44122:
URL: https://github.com/apache/superset/pull/44122#issuecomment-5609916418

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(boxplot): preserve null grouping values [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44122:
URL: https://github.com/apache/superset/pull/44122#issuecomment-5610050675

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44122?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `1 line` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 57.48%. Comparing base ([`62fa7a3`](https://app.codecov.io/gh/apache/superset/commit/62fa7a371b842437d4c8c9d7a039dd5666cdb373?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`764d010`](https://app.codecov.io/gh/apache/superset/commit/764d0105832f6091d70c97dad8caafc6efa185e8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 1 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/44122?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [superset/utils/pandas\_postprocessing/aggregate.py](https://app.codecov.io/gh/apache/superset/pull/44122?src=pr&el=tree&filepath=superset%2Futils%2Fpandas_postprocessing%2Faggregate.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nL2FnZ3JlZ2F0ZS5weQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/44122?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   > :exclamation:  There is a different number of reports uploaded between BASE (62fa7a3) and HEAD (764d010). Click for more details.
   > 
   > <details><summary>HEAD has 4 uploads less than BASE</summary>
   >
   >| Flag | BASE (62fa7a3) | HEAD (764d010) |
   >|------|------|------|
   >|python|6|2|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #44122      +/-   ##
   ==========================================
   - Coverage   66.46%   57.48%   -8.98%     
   ==========================================
     Files        2923     2923              
     Lines      172215   172215              
     Branches    39981    39981              
   ==========================================
   - Hits       114457    99000   -15457     
   - Misses      55382    72284   +16902     
   + Partials     2376      931    -1445     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/44122/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Ξ” | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/44122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `37.36% <0.00%> (ΓΈ)` | |
   | [mysql](https://app.codecov.io/gh/apache/superset/pull/44122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/44122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/44122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.25% <0.00%> (ΓΈ)` | |
   | [python](https://app.codecov.io/gh/apache/superset/pull/44122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.30% <0.00%> (-17.94%)` | :arrow_down: |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/44122/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44122?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(boxplot): preserve null grouping values [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #44122:
URL: https://github.com/apache/superset/pull/44122#issuecomment-6356669003

   @uyivzola CI looked green here but it's conflicting now. Can you rebase so we can get this reviewed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org