[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6571: Minor: Move `PlanType`, `StringifiedPlan` and `ToStringifiedPlan` `datafusion_common`

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6571:
URL: https://github.com/apache/arrow-datafusion/pull/6571#discussion_r1225328754


##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -42,7 +42,8 @@ use std::fmt::{self, Debug, Display, Formatter};
 use std::hash::{Hash, Hasher};
 use std::sync::Arc;
 
-// backwards compatible
+// backwards compatibility
+pub use datafusion_common::display::{PlanType, StringifiedPlan, ToStringifiedPlan};

Review Comment:
   I tried to add a deprecated message (that could point people to use the new location) but it didn't seem to work for.
   
   I think we can remove the `pub use` whenever we want, it will simply mean users of the crate will have to update their `pub use`s. 
   
   I guess I am hoping that over time we can remove some of the old `pub use` but we don't really have a structured plan for doing so. 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org