You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/14 13:44:20 UTC

[GitHub] [cloudstack] DaanHoogland opened a new pull request #3814: Add missing HA config keys (#3776)

DaanHoogland opened a new pull request #3814:  Add missing HA config keys (#3776)
URL: https://github.com/apache/cloudstack/pull/3814
 
 
   ## Description
   <!--- Describe your changes in detail -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3814: Add missing HA config keys (#3776)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3814:  Add missing HA config keys (#3776)
URL: https://github.com/apache/cloudstack/pull/3814#issuecomment-574250357
 
 
   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] andrijapanicsb commented on issue #3814: Add missing HA config keys (#3776)

Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on issue #3814:  Add missing HA config keys (#3776)
URL: https://github.com/apache/cloudstack/pull/3814#issuecomment-574614654
 
 
   You know your stuff @DaanHoogland - so if you are happy, yes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3814: Add missing HA config keys (#3776)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3814:  Add missing HA config keys (#3776)
URL: https://github.com/apache/cloudstack/pull/3814#issuecomment-574201195
 
 
   Packaging result: ✖centos6 ✖centos7 ✖debian. JID-596

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] svenvogel commented on issue #3814: Add missing HA config keys (#3776)

Posted by GitBox <gi...@apache.org>.
svenvogel commented on issue #3814:  Add missing HA config keys (#3776)
URL: https://github.com/apache/cloudstack/pull/3814#issuecomment-574189127
 
 
   @DaanHoogland how it looks like?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3814: Add missing HA config keys (#3776)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3814:  Add missing HA config keys (#3776)
URL: https://github.com/apache/cloudstack/pull/3814#issuecomment-574232188
 
 
   Packaging result: ✖centos6 ✔centos7 ✔debian. JID-599

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland merged pull request #3814: Add missing HA config keys (#3776)

Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #3814: Add missing HA config keys (#3776)
URL: https://github.com/apache/cloudstack/pull/3814
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3814: Add missing HA config keys (#3776)

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3814:  Add missing HA config keys (#3776)
URL: https://github.com/apache/cloudstack/pull/3814#issuecomment-574221644
 
 
   @blueorangutan package

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3814: Add missing HA config keys (#3776)

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3814:  Add missing HA config keys (#3776)
URL: https://github.com/apache/cloudstack/pull/3814#issuecomment-574192902
 
 
   @svenvogel it passed all tests on 4.13. it had merge conflict so i'll run tests again here.
   @blueorangutan package

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3814: Add missing HA config keys (#3776)

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3814:  Add missing HA config keys (#3776)
URL: https://github.com/apache/cloudstack/pull/3814#issuecomment-574564068
 
 
   @andrijapanicsb this is forward merged from the 4.13 branch and had LGTMs and tests. It had merge conflicts however but all looks fine now. merge?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] DaanHoogland commented on issue #3814: Add missing HA config keys (#3776)

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3814:  Add missing HA config keys (#3776)
URL: https://github.com/apache/cloudstack/pull/3814#issuecomment-574250152
 
 
   @blueorangutan test

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3814: Add missing HA config keys (#3776)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3814:  Add missing HA config keys (#3776)
URL: https://github.com/apache/cloudstack/pull/3814#issuecomment-574193167
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3814: Add missing HA config keys (#3776)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3814:  Add missing HA config keys (#3776)
URL: https://github.com/apache/cloudstack/pull/3814#issuecomment-574221846
 
 
   @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [cloudstack] blueorangutan commented on issue #3814: Add missing HA config keys (#3776)

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3814:  Add missing HA config keys (#3776)
URL: https://github.com/apache/cloudstack/pull/3814#issuecomment-574443395
 
 
   <b>Trillian test result (tid-771)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 29028 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3814-t771-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 78 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services