You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/02/24 00:37:09 UTC
[GitHub] [libcloud] robjuffermans opened a new pull request #1555: status RESIZE of node was not implemented
robjuffermans opened a new pull request #1555:
URL: https://github.com/apache/libcloud/pull/1555
## added node status RESIZE for OVH
### Description
added to NODE_STATE_MAP and test for OVH
### Status
- done, ready for review
closes #1554
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on a change in pull request #1555: status RESIZE of node was not implemented
Posted by GitBox <gi...@apache.org>.
Kami commented on a change in pull request #1555:
URL: https://github.com/apache/libcloud/pull/1555#discussion_r583964284
##########
File path: libcloud/compute/drivers/openstack.py
##########
@@ -120,6 +120,7 @@ class OpenStackNodeDriver(NodeDriver, OpenStackDriverMixin):
'PASSWORD': NodeState.PENDING,
'RESCUE': NodeState.PENDING,
'REBOOT': NodeState.REBOOTING,
+ 'RESIZE': NodeState.MIGRATING,
Review comment:
I'll make a small change so it uses ``reconfiguring`` state instead, but besides that, LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] asfgit merged pull request #1555: status RESIZE of node was not implemented
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #1555:
URL: https://github.com/apache/libcloud/pull/1555
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on pull request #1555: status RESIZE of node was not implemented
Posted by GitBox <gi...@apache.org>.
Kami commented on pull request #1555:
URL: https://github.com/apache/libcloud/pull/1555#issuecomment-786937196
Thanks for the contribution. Changes have been merged into trunk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami commented on a change in pull request #1555: status RESIZE of node was not implemented
Posted by GitBox <gi...@apache.org>.
Kami commented on a change in pull request #1555:
URL: https://github.com/apache/libcloud/pull/1555#discussion_r583964433
##########
File path: libcloud/compute/drivers/openstack.py
##########
@@ -120,6 +120,7 @@ class OpenStackNodeDriver(NodeDriver, OpenStackDriverMixin):
'PASSWORD': NodeState.PENDING,
'RESCUE': NodeState.PENDING,
'REBOOT': NodeState.REBOOTING,
+ 'RESIZE': NodeState.MIGRATING,
Review comment:
Also, I didn't actually know it utilizes states from OpenStack driver.
Technically, this change should be safe either way so it's fine to add it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org