[GitHub] [tvm] driazati commented on a diff in pull request #12509: [Target] Add target_device_type attribute to override default device_type

[GitBox <gi...@apache.org>]

driazati commented on code in PR #12509:
URL: https://github.com/apache/tvm/pull/12509#discussion_r953091382


##########
include/tvm/target/target_kind.h:
##########
@@ -102,7 +102,7 @@ class TargetKindNode : public Object {
 
   void VisitAttrs(AttrVisitor* v) {
     v->Visit("name", &name);
-    v->Visit("device_type", &device_type);
+    v->Visit("default_device_type", &default_device_type);

Review Comment:
   sounds like a good idea that would make generating coherent release notes a lot easier (at least to highlight big changes). line items like this should be enough:
   
   ```
   * #<pr number>: <description>
   * #12509: this does X changes API A from Y to Z
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org