You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@click.apache.org by bc...@apache.org on 2010/07/09 12:21:12 UTC
svn commit: r962474 - in
/click/trunk/click/framework/src/org/apache/click/control: ActionLink.java
Checkbox.java FileField.java ImageSubmit.java Label.java PageLink.java
PasswordField.java Radio.java Reset.java TextArea.java TextField.java
Author: bckfnn
Date: Fri Jul 9 10:21:12 2010
New Revision: 962474
URL: http://svn.apache.org/viewvc?rev=962474&view=rev
Log:
add @Override
Modified:
click/trunk/click/framework/src/org/apache/click/control/ActionLink.java
click/trunk/click/framework/src/org/apache/click/control/Checkbox.java
click/trunk/click/framework/src/org/apache/click/control/FileField.java
click/trunk/click/framework/src/org/apache/click/control/ImageSubmit.java
click/trunk/click/framework/src/org/apache/click/control/Label.java
click/trunk/click/framework/src/org/apache/click/control/PageLink.java
click/trunk/click/framework/src/org/apache/click/control/PasswordField.java
click/trunk/click/framework/src/org/apache/click/control/Radio.java
click/trunk/click/framework/src/org/apache/click/control/Reset.java
click/trunk/click/framework/src/org/apache/click/control/TextArea.java
click/trunk/click/framework/src/org/apache/click/control/TextField.java
Modified: click/trunk/click/framework/src/org/apache/click/control/ActionLink.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/ActionLink.java?rev=962474&r1=962473&r2=962474&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/ActionLink.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/ActionLink.java Fri Jul 9 10:21:12 2010
@@ -340,6 +340,7 @@ public class ActionLink extends Abstract
*
* @return the ActionLink anchor <a> tag HTML href attribute value
*/
+ @Override
public String getHref() {
return getHref(getValue());
}
Modified: click/trunk/click/framework/src/org/apache/click/control/Checkbox.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/Checkbox.java?rev=962474&r1=962473&r2=962474&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/Checkbox.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/Checkbox.java Fri Jul 9 10:21:12 2010
@@ -115,6 +115,7 @@ public class Checkbox extends Field {
*
* @return this controls html tag
*/
+ @Override
public String getTag() {
return "input";
}
@@ -153,6 +154,7 @@ public class Checkbox extends Field {
*
* @return the Field value
*/
+ @Override
public String getValue() {
return String.valueOf(checked);
}
@@ -165,6 +167,7 @@ public class Checkbox extends Field {
*
* @param value the Field value
*/
+ @Override
public void setValue(String value) {
checked = Boolean.valueOf(value);
}
@@ -176,6 +179,7 @@ public class Checkbox extends Field {
*
* @return the object representation of the Field value
*/
+ @Override
public Object getValueObject() {
if (checked) {
return Boolean.TRUE;
@@ -192,6 +196,7 @@ public class Checkbox extends Field {
*
* @param object the object value to set
*/
+ @Override
public void setValueObject(Object object) {
if (object != null && object instanceof Boolean) {
checked = (Boolean) object;
@@ -203,6 +208,7 @@ public class Checkbox extends Field {
*
* @return the field JavaScript client side validation function
*/
+ @Override
public String getValidationJavaScript() {
if (isRequired()) {
Object[] args = new Object[3];
@@ -223,6 +229,7 @@ public class Checkbox extends Field {
* Set the {@link #checked} property to true if the fields value is
* submitted.
*/
+ @Override
public void bindRequestValue() {
setChecked(getContext().getRequestParameter(getName()) != null);
}
@@ -234,6 +241,7 @@ public class Checkbox extends Field {
*
* @param buffer the specified buffer to render the control's output to
*/
+ @Override
public void render(HtmlStringBuffer buffer) {
buffer.elementStart(getTag());
@@ -283,6 +291,7 @@ public class Checkbox extends Field {
* checked the error message defined by <tt>not-checked-error</tt>
* property will be displayed.
*/
+ @Override
public void validate() {
if (isRequired() && !isChecked()) {
setErrorMessage("not-checked-error");
Modified: click/trunk/click/framework/src/org/apache/click/control/FileField.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/FileField.java?rev=962474&r1=962473&r2=962474&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/FileField.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/FileField.java Fri Jul 9 10:21:12 2010
@@ -176,6 +176,7 @@ public class FileField extends Field {
*
* @return this controls html tag
*/
+ @Override
public String getTag() {
return "input";
}
@@ -222,6 +223,7 @@ public class FileField extends Field {
*
* @return the field JavaScript client side validation function
*/
+ @Override
public String getValidationJavaScript() {
if (isRequired()) {
Object[] args = new Object[3];
@@ -242,6 +244,7 @@ public class FileField extends Field {
* Set the {@link #fileItem} property from the multi-part form data
* submission.
*/
+ @Override
public void bindRequestValue() {
fileItem = getContext().getFileItem(getName());
}
@@ -251,6 +254,7 @@ public class FileField extends Field {
*
* @return the estimated rendered control size in characters
*/
+ @Override
public int getControlSizeEst() {
return 96;
}
@@ -262,6 +266,7 @@ public class FileField extends Field {
*
* @param buffer the specified buffer to render the control's output to
*/
+ @Override
public void render(HtmlStringBuffer buffer) {
buffer.elementStart(getTag());
@@ -311,6 +316,7 @@ public class FileField extends Field {
* </ul>
* </blockquote>
*/
+ @Override
public void validate() {
setError(null);
Modified: click/trunk/click/framework/src/org/apache/click/control/ImageSubmit.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/ImageSubmit.java?rev=962474&r1=962473&r2=962474&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/ImageSubmit.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/ImageSubmit.java Fri Jul 9 10:21:12 2010
@@ -126,6 +126,7 @@ public class ImageSubmit extends Submit
*
* @return the input type: '<tt>image</tt>'
*/
+ @Override
public String getType() {
return "image";
}
@@ -180,6 +181,7 @@ public class ImageSubmit extends Submit
* Bind the request submission, setting the field {@link Submit#clicked},
* {@link #x} and {@link #y} if defined in the request.
*/
+ @Override
public void bindRequestValue() {
Context context = getContext();
@@ -212,6 +214,7 @@ public class ImageSubmit extends Submit
*
* @param buffer the specified buffer to render the control's output to
*/
+ @Override
public void render(HtmlStringBuffer buffer) {
buffer.elementStart(getTag());
Modified: click/trunk/click/framework/src/org/apache/click/control/Label.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/Label.java?rev=962474&r1=962473&r2=962474&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/Label.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/Label.java Fri Jul 9 10:21:12 2010
@@ -90,6 +90,7 @@ public class Label extends Field {
*
* @return true to continue Page event processing or false otherwise
*/
+ @Override
public boolean onProcess() {
return true;
}
@@ -101,6 +102,7 @@ public class Label extends Field {
*
* @param buffer the specified buffer to render the control's output to
*/
+ @Override
public void render(HtmlStringBuffer buffer) {
buffer.append(getLabel());
}
@@ -112,6 +114,7 @@ public class Label extends Field {
*
* @return the label string value
*/
+ @Override
public String toString() {
return getLabel();
}
Modified: click/trunk/click/framework/src/org/apache/click/control/PageLink.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/PageLink.java?rev=962474&r1=962473&r2=962474&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/PageLink.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/PageLink.java Fri Jul 9 10:21:12 2010
@@ -127,6 +127,7 @@ public class PageLink extends AbstractLi
*
* @return the PageLink HTML href attribute
*/
+ @Override
public String getHref() {
if (getPageClass() == null) {
throw new IllegalStateException("target pageClass is not defined");
@@ -161,6 +162,7 @@ public class PageLink extends AbstractLi
*
* @param listener the listener to invoke
*/
+ @Override
public void setActionListener(ActionListener listener) {
}
@@ -172,6 +174,7 @@ public class PageLink extends AbstractLi
* @param listener the listener object with the named method to invoke
* @param method the name of the method to invoke
*/
+ @Override
public void setListener(Object listener, String method) {
}
@@ -203,6 +206,7 @@ public class PageLink extends AbstractLi
*
* @return true
*/
+ @Override
public boolean onProcess() {
return true;
}
Modified: click/trunk/click/framework/src/org/apache/click/control/PasswordField.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/PasswordField.java?rev=962474&r1=962473&r2=962474&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/PasswordField.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/PasswordField.java Fri Jul 9 10:21:12 2010
@@ -125,6 +125,7 @@ public class PasswordField extends TextF
*
* @return the input type: '<tt>password</tt>'
*/
+ @Override
public String getType() {
return "password";
}
Modified: click/trunk/click/framework/src/org/apache/click/control/Radio.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/Radio.java?rev=962474&r1=962473&r2=962474&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/Radio.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/Radio.java Fri Jul 9 10:21:12 2010
@@ -102,6 +102,7 @@ public class Radio extends Field {
*
* @return this controls html tag
*/
+ @Override
public String getTag() {
return "input";
}
@@ -130,6 +131,7 @@ public class Radio extends Field {
*
* @return HTML element identifier attribute "id" value
*/
+ @Override
public String getId() {
if (hasAttributes() && getAttributes().containsKey("id")) {
return getAttribute("id");
@@ -172,6 +174,7 @@ public class Radio extends Field {
* @throws IllegalArgumentException if the given parent instance is
* referencing <tt>this</tt> object: <tt>if (parent == this)</tt>
*/
+ @Override
public void setParent(Object parent) {
if (parent == this) {
throw new IllegalArgumentException("Cannot set parent to itself");
@@ -229,6 +232,7 @@ public class Radio extends Field {
*
* @return the display label of the Field
*/
+ @Override
public String getLabel() {
if (label == null) {
if (super.getName() != null) {
@@ -255,6 +259,7 @@ public class Radio extends Field {
*
* @return the name of the control
*/
+ @Override
public String getName() {
if (super.getName() != null) {
return super.getName();
@@ -288,6 +293,7 @@ public class Radio extends Field {
*
* @param value the Field value
*/
+ @Override
public void setValue(String value) {
setChecked(getValue().equals(value));
super.setValue(value);
@@ -299,6 +305,7 @@ public class Radio extends Field {
* Bind the request submission, setting the Field {@link #checked} property
* if defined in the request.
*/
+ @Override
public void bindRequestValue() {
String value = getRequestValue();
@@ -341,6 +348,7 @@ public class Radio extends Field {
*
* @param buffer the specified buffer to render the control's output to
*/
+ @Override
public void render(HtmlStringBuffer buffer) {
String id = getId();
Modified: click/trunk/click/framework/src/org/apache/click/control/Reset.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/Reset.java?rev=962474&r1=962473&r2=962474&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/Reset.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/Reset.java Fri Jul 9 10:21:12 2010
@@ -92,6 +92,7 @@ public class Reset extends Button {
*
* @return the input type: '<tt>reset</tt>'
*/
+ @Override
public String getType() {
return "reset";
}
Modified: click/trunk/click/framework/src/org/apache/click/control/TextArea.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/TextArea.java?rev=962474&r1=962473&r2=962474&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/TextArea.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/TextArea.java Fri Jul 9 10:21:12 2010
@@ -215,6 +215,7 @@ public class TextArea extends Field {
*
* @return this controls html tag
*/
+ @Override
public String getTag() {
return "textarea";
}
@@ -306,6 +307,7 @@ public class TextArea extends Field {
*
* @return the estimated rendered control size in characters
*/
+ @Override
public int getControlSizeEst() {
return 96;
}
@@ -317,6 +319,7 @@ public class TextArea extends Field {
*
* @param buffer the specified buffer to render the control's output to
*/
+ @Override
public void render(HtmlStringBuffer buffer) {
buffer.elementStart(getTag());
@@ -373,6 +376,7 @@ public class TextArea extends Field {
* <li>field-required-error</li>
* </ul></blockquote>
*/
+ @Override
public void validate() {
setError(null);
@@ -407,6 +411,7 @@ public class TextArea extends Field {
*
* @return the field JavaScript client side validation function
*/
+ @Override
public String getValidationJavaScript() {
Object[] args = new Object[7];
args[0] = getId();
Modified: click/trunk/click/framework/src/org/apache/click/control/TextField.java
URL: http://svn.apache.org/viewvc/click/trunk/click/framework/src/org/apache/click/control/TextField.java?rev=962474&r1=962473&r2=962474&view=diff
==============================================================================
--- click/trunk/click/framework/src/org/apache/click/control/TextField.java (original)
+++ click/trunk/click/framework/src/org/apache/click/control/TextField.java Fri Jul 9 10:21:12 2010
@@ -198,6 +198,7 @@ public class TextField extends Field {
*
* @return this controls html tag
*/
+ @Override
public String getTag() {
return "input";
}
@@ -286,6 +287,7 @@ public class TextField extends Field {
*
* @return the estimated rendered control size in characters
*/
+ @Override
public int getControlSizeEst() {
return 96;
}
@@ -297,6 +299,7 @@ public class TextField extends Field {
*
* @param buffer the specified buffer to render the control's output to
*/
+ @Override
public void render(HtmlStringBuffer buffer) {
buffer.elementStart(getTag());
@@ -354,6 +357,7 @@ public class TextField extends Field {
* <li>field-required-error</li>
* </ul></blockquote>
*/
+ @Override
public void validate() {
setError(null);
@@ -387,6 +391,7 @@ public class TextField extends Field {
*
* @return the field JavaScript client side validation function
*/
+ @Override
public String getValidationJavaScript() {
Object[] args = new Object[7];
args[0] = getId();