[GitHub] [solr] janhoy commented on a change in pull request #268: SOLR-15324 Upgrade Jaeger dependency from 1.1.0 to 1.6.0

[GitBox <gi...@apache.org>]

janhoy commented on a change in pull request #268:
URL: https://github.com/apache/solr/pull/268#discussion_r692017506



##########
File path: versions.lock
##########
@@ -174,11 +174,13 @@ org.apache.poi:poi:4.1.1 (1 constraints: 08050336)
 org.apache.poi:poi-ooxml:4.1.1 (1 constraints: 08050336)
 org.apache.poi:poi-ooxml-schemas:4.1.1 (1 constraints: 08050336)
 org.apache.poi:poi-scratchpad:4.1.1 (1 constraints: 08050336)
-org.apache.thrift:libthrift:0.13.0 (1 constraints: 8e0dfd33)
+org.apache.thrift:libthrift:0.14.1 (1 constraints: 900d0134)
 org.apache.tika:tika-core:1.24 (1 constraints: db04f730)
 org.apache.tika:tika-java7:1.24 (1 constraints: db04f730)
 org.apache.tika:tika-parsers:1.24 (1 constraints: db04f730)
 org.apache.tika:tika-xmp:1.24 (1 constraints: db04f730)
+org.apache.tomcat:tomcat-annotations-api:8.5.46 (1 constraints: 5a1162ea)
+org.apache.tomcat.embed:tomcat-embed-core:8.5.46 (1 constraints: 780c4b05)

Review comment:
       Would it be safe to exclude these two new tomcat dependencies or are they needed by our use of jaeger?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org