You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/09/22 10:53:13 UTC
[GitHub] [trafficserver] brbzull0 opened a new pull request #8343: Rename outbound_conntrack to global_outbound_conntrack to reduce confusion.
brbzull0 opened a new pull request #8343:
URL: https://github.com/apache/trafficserver/pull/8343
Trying to reduce confusion between the following two structures.
```
OutboundConnTrack::TxnConfig outbound_conntrack;
OutboundConnTrack::GlobalConfig outbound_conntrack;
```
This is a follow up of https://github.com/apache/trafficserver/pull/8328
_Open for discussion how to make this a bit better._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8343: Rename outbound_conntrack to global_outbound_conntrack to reduce confusion.
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8343:
URL: https://github.com/apache/trafficserver/pull/8343#issuecomment-925059197
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop merged pull request #8343: Rename outbound_conntrack to global_outbound_conntrack to reduce confusion.
Posted by GitBox <gi...@apache.org>.
zwoop merged pull request #8343:
URL: https://github.com/apache/trafficserver/pull/8343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8343: Rename outbound_conntrack to global_outbound_conntrack to reduce confusion.
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8343:
URL: https://github.com/apache/trafficserver/pull/8343#issuecomment-924996804
Thanks for helping clarify this.
If we're qualifying the one to be global_outbound_conntrack, it may be helpful to qualify the other to be transaction_outbound_conntrack.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #8343: Rename outbound_conntrack to global_outbound_conntrack to reduce confusion.
Posted by GitBox <gi...@apache.org>.
brbzull0 commented on pull request #8343:
URL: https://github.com/apache/trafficserver/pull/8343#issuecomment-925099422
> Thanks for helping clarify this.
>
> If we're qualifying the one to be global_outbound_conntrack, it may be helpful to qualify the other to be transaction_outbound_conntrack.
I have been told that the "txn" nature is implicit in being in the `oride`, so I only changed one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org