You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/13 00:16:53 UTC
[GitHub] [iceberg] jackye1995 commented on a diff in pull request #4695: AWS: Add Cache for LakeFormation Credentials
jackye1995 commented on code in PR #4695:
URL: https://github.com/apache/iceberg/pull/4695#discussion_r969031806
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -410,6 +410,32 @@ public class AwsProperties implements Serializable {
*/
public static final String LAKE_FORMATION_DB_NAME = "lakeformation.db-name";
+ /**
+ * Used by {@link LakeFormationAwsClientFactory}. The maximum size of the lakeformation
+ * credentials cache, default to 100.
+ */
+ public static final String LAKE_FORMATION_CACHE_MAX_SIZE = "lakeformation.cache.max-size";
+
+ public static final int LAKE_FORMATION_CACHE_MAX_SIZE_DEFAULT = 100;
+
+ /**
+ * Used by {@link LakeFormationAwsClientFactory}. The expiry time of the cached lakeformation
+ * credentials in milliseconds, default to 30 minutes.
+ */
+ public static final String LAKE_FORMATION_CACHE_EXPIRATION_INTERVAL_MS =
+ "lakeformation.cache.expiration-interval-ms";
+
+ public static final long LAKE_FORMATION_CACHE_EXPIRATION_INTERVAL_MS_DEFAULT = 30 * 60 * 1000;
+
+ /**
+ * Used by {@link LakeFormationAwsClientFactory}. The expiry lead time of the lakeformation
+ * credentials cache, default to 1 minute.
+ */
+ public static final String LAKE_FORMATION_CACHE_EXPIRY_LEAD_TIME_MS =
Review Comment:
the name and config name is not matching, `REFRESH_LEAD_TIME_MS`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org